many failures on android bots |
||||||
Issue descriptionI've been seeing a ton of failures on all the android bots, which all seemed to have started at around the same time. It looks like they're crashes. I think I've narrowed the revision range down to https://chromium.googlesource.com/chromium/src/+log/23d7fb4389c98a96be6607b72fd58a92d5d11fd8%5E..d60fffd82610b50797b45ba9dd9ad58fdccc9141. At a glance I don't see anything bad. Some links to builders you can click on: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf Not sure who's the best person to try to diagnose this?
,
Oct 3 2017
I'll start up some bisects.
,
Oct 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8966714471565250032
,
Oct 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8966714343113946416
,
Oct 4 2017
=== Auto-CCing suspected CL author beccahughes@chromium.org === Hi beccahughes@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : Becca Hughes Commit : 3b0c080b0bb28d3d8616d863f0302053dd1dbf42 Date : Tue Oct 03 08:42:02 2017 Subject: Reland "Media Controls: Load CSS directly in Blink" Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : v8.runtimestats.browsing_mobile Metric : API:count_avg/browse_media/browse_media_imgur Revision Exit Code N chromium@505957 0 +- N/A 3 good chromium@505972 0 +- N/A 3 good chromium@505981 0 +- N/A 3 good chromium@505984 0 +- N/A 3 good chromium@505985 1 +- N/A 3 bad <-- chromium@505986 1 +- N/A 3 bad chromium@505990 1 +- N/A 3 bad chromium@506023 1 +- N/A 3 bad chromium@506089 1 +- N/A 3 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur v8.runtimestats.browsing_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8966714471565250032 For feedback, file a bug with component Speed>Bisection
,
Oct 4 2017
=== BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : Becca Hughes Commit : 3b0c080b0bb28d3d8616d863f0302053dd1dbf42 Date : Tue Oct 03 08:42:02 2017 Subject: Reland "Media Controls: Load CSS directly in Blink" Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : smoothness.key_mobile_sites_smooth Metric : avg_surface_fps/http___www.boingboing.net Revision Exit Code N chromium@505937 0 +- N/A 3 good chromium@505972 0 +- N/A 3 good chromium@505981 0 +- N/A 3 good chromium@505983 0 +- N/A 3 good chromium@505984 0 +- N/A 3 good chromium@505985 1 +- N/A 3 bad <-- chromium@505989 1 +- N/A 3 bad chromium@506006 1 +- N/A 3 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.boingboing.net smoothness.key_mobile_sites_smooth More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8966714343113946416 For feedback, file a bug with component Speed>Bisection
,
Oct 4 2017
=== BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : Becca Hughes Commit : 3b0c080b0bb28d3d8616d863f0302053dd1dbf42 Date : Tue Oct 03 08:42:02 2017 Subject: Reland "Media Controls: Load CSS directly in Blink" Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : system_health.common_mobile Metric : cpu_time_percentage_avg/background_news/background_news_nytimes Revision Exit Code N chromium@505690 0 +- N/A 3 good chromium@505871 0 +- N/A 3 good chromium@505963 0 +- N/A 3 good chromium@505972 0 +- N/A 3 good chromium@505979 0 +- N/A 3 good chromium@505982 0 +- N/A 3 good chromium@505984 0 +- N/A 3 good chromium@505985 1 +- N/A 3 bad <-- chromium@506007 1 +- N/A 3 bad chromium@506051 1 +- N/A 3 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.news.nytimes system_health.common_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8966714638839645504 For feedback, file a bug with component Speed>Bisection
,
Oct 4 2017
,
Oct 4 2017
Added a CL to fix https://chromium-review.googlesource.com/c/chromium/src/+/700495
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f25a0c9b64da1e0b9d1c14a19735c690c32a189e commit f25a0c9b64da1e0b9d1c14a19735c690c32a189e Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 04 14:25:06 2017 Fix Android crash in media controls Official Android builds scrape the build logs looking for "unknown pragma" warnings and then remove any resources that don't have a corresponding warning. This means that the media controls resources were not getting included in Android builds causing a crash. BUG=771507,771513,771512, 771397 Change-Id: Icde2be4a881b5e2e06e45a725f6983fe6b280967 Reviewed-on: https://chromium-review.googlesource.com/700495 Reviewed-by: Anton Vayvod <avayvod@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506384} [modify] https://crrev.com/f25a0c9b64da1e0b9d1c14a19735c690c32a189e/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp
,
Oct 4 2017
Issue 771593 has been merged into this issue.
,
Oct 4 2017
Issue 771599 has been merged into this issue.
,
Oct 4 2017
Issue 771590 has been merged into this issue.
,
Oct 4 2017
This builder has now built the fix (#383) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf and the media tests are now working. "v8.runtimestats.browsing_mobile" is failing but it was also failing before. I'm going to reassign this back to martiniss@
,
Oct 4 2017
Issue 771602 has been merged into this issue.
,
Oct 4 2017
The builders seem to be fixed, so I'm marking this as fixed. Thanks!
,
Oct 5 2017
Issue 771385 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 3 2017