Wrong file name when downloading video
Reported by
michael....@gmail.com,
Oct 3 2017
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Example URL: https://videomail.io/videomail/bad-download-file-name-on-chrome-598597282413 Steps to reproduce the problem: 1. open that page 2. click on the download icon on that video 3. open that file, it's called "download" without extension What is the expected behavior? that video file should have at least the extension .webm, called `download.webm` or so. What went wrong? saved video has no extension. plus there is no documentation how the HTML markup can set it's file name. would like to control how it's called. (i'm the developer of that site) Did this work before? N/A Chrome version: 61.0.3163.100 Channel: stable OS Version: OS X 10.13.0 Flash Version:
,
Oct 4 2017
,
Oct 5 2017
michael.heuberger.binarykitchen@ Thanks for the issue. Able to reproduce this issue on Mac OS 10.12.6, Windows 7 and Ubuntu 14.04 using the latest Stable 61.0.3163.100, but unable to reproduce this issue on the latest Canary 63.0.3233.0. Performed reverse bisect and below is the Bisect Information. Reverse Bisect Information: ===================== Good build: 62.0.3164.0 Bad Build : 61.0.3163.116. Note: As the good and bad builds are from different milestones and the bad build is a branch build, cannot execute the per-revision script for finding the Suspect CL. Hence through Manual Bisect providing the Changelog URL from Omahaproxy. Below is the Change Log URL : ================== https://chromium.googlesource.com/chromium/src/+log/61.0.3163.0..62.0.3164.0?pretty=fuller&n=10000 As we are unable to find the right suspect from the above ChangeLog, requesting someone from Dev to look into the issue. Hence marking this issue as Untriaged for further update from Dev. Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove if this is not the case. Thanks..
,
Oct 5 2017
,
Oct 5 2017
,
Oct 9 2017
Can't reproduce on trunk on Ubuntu 14.04. The file name extension is generated mainly based on mime type. The mime type currently for this URL is video/webm, which seems to be correct. In the bisect, one CL changed the mime type and file name generation code, which looks suspicious. https://chromium-review.googlesource.com/578649
,
Oct 9 2017
I think commit 77132a2bc78e8dc9ce411e8166bfd009f6476f6f actually fixed this issue. Mark this as won't fix, since 62 stable is approaching, we probably don't want this fix in 61? Feel free to change it back if we do need the fix commit for 61 stable. Also I checked our android code, which we use android::GetMimeTypeFromExtension which uses some Java library, so this bug should not affect android.
,
Oct 10 2017
one second. have two more questions: - is there really unit test coverage to make sure this won't happen again? - still unanswered: how the HTML markup can set it's file name? currently it's always called 'download'
,
Oct 10 2017
To michael.heuberger.binarykitchen@, 1. We have filename_util_unittest.cc but coverage may not be good. I'll dig a bit more on that test. 2. <a> download attribute should work for normal download. But I'm not sure if there is any standard in html to specified a video download name. In Content-Disposition HTTP response header, there is a filename params that can be specified. This should be a reliable way to let Chrome to generate the correct extension.
,
Oct 10 2017
Also the URI in <source> is used by Chrome, but the last component in the website doesn't look like an extension, so the file name generation logic is probably not recognizing it as file name. It might be helpful to change the URI to something like: <source src="movie.mp4" type="video/mp4"> And Chrome will figure out the file name from URL, if there is no content disposition in the response header.
,
Oct 10 2017
sweet, yeah please ensure solid unit test coverage here. about the Content-Disposition HTTP response header, yeah, that fixed it. thanks for pointing to this.
,
Mar 15 2018
,
Mar 15 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nyerramilli@chromium.org
, Oct 4 2017