New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771390 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Log headers for non-200 responses for http request made by Findit to external services.

Project Member Reported by robert...@chromium.org, Oct 3 2017

Issue description

This may help us debug problems.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8946f12d0e4d38923120d1c144574aaaedebd156

commit 8946f12d0e4d38923120d1c144574aaaedebd156
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Oct 13 18:53:40 2017

[Findit] Log HTTP non-200 response headers from external services.

This needed to change the number of values in the response tuple for
the private implementations _Get() _Post() and _Put() only.

Calls to .Get(), .Put() and .Post() throughout the project remain
unchanged.

R=katesonia,chanli,stgao,lijeffrey,wylieb
BUG= 771390 

Change-Id: Id79ce9c03d82755e00e8b908f0e0d84d36c48530
Reviewed-on: https://chromium-review.googlesource.com/717819
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Sharu Jiang <katesonia@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/common/test/findit_http_client_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/http/test/retry_http_client_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/http/test/interceptor_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/gae_libs/http/test/auth_util_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/deps/test/chrome_dependency_fetcher_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/gae_libs/http/http_client_appengine.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/http/retry_http_client.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/common/test/rotations_test.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/http/interceptor.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/libs/base_testcase.py
[modify] https://crrev.com/8946f12d0e4d38923120d1c144574aaaedebd156/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py

Status: Fixed (was: Started)

Sign in to add a comment