New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771389 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: Oct 2017
Cc:
█ reve...@chromium.org
varkha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Defer painting during overview mode enter/exit animations

Project Member Reported by wutao@chromium.org, Oct 3 2017 
We want to defer layer painting during overview mode animations so that we can:
1. Use trilinear filter,
2. Cache the render suface of the animating layer.

This should only apply to the window itself, not the fake caption. We still want the caption color change animations during the overview mode animations.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c962fd88f839085826a875ed66b57d80195b6c9d

commit c962fd88f839085826a875ed66b57d80195b6c9d
Author: wutao <wutao@chromium.org>
Date: Mon Oct 09 22:06:53 2017

Defer painting in overview mode animations.

This defers layer painting during overview mode animations. Any
|damaged_region_| in SchedulePaint() on the overview window will
be accumulated and drawn after the enter/exit animations finish.

By deferring layer painting, it can reduce the chance that trilinear
filtering and render surface caching improvements would not provide
a performance benefit. If we repaint each frame then those changes
would result in a negative performance impact instead of a positive one.

Bug:  771389 
Test: Check the paint is deferred and updated at the end of animations.
Change-Id: I6b625afbac573d7cc87538b97bb2e9cda4837b43
Reviewed-on: https://chromium-review.googlesource.com/701423
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507504}
[modify] https://crrev.com/c962fd88f839085826a875ed66b57d80195b6c9d/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/c962fd88f839085826a875ed66b57d80195b6c9d/ash/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/c962fd88f839085826a875ed66b57d80195b6c9d/ash/wm/overview/scoped_transform_overview_window.cc

Comment 2 by wutao@chromium.org, Oct 10 2017

Status: Fixed (was: Available)
►

Sign in to add a comment