New issue
Advanced search Search tips

Issue 771386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Use libbrillo Chrome proxy checking in update_engine

Project Member Reported by jkardatzke@chromium.org, Oct 3 2017

Issue description

Update the code in aosp/system/update_engine to use the new function in libbrillo that will get the proxy server list from Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/cf5f1f1420b472477317b0ea0fa7f6456d2605cf

commit cf5f1f1420b472477317b0ea0fa7f6456d2605cf
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Tue Oct 10 03:07:57 2017

Update to use libbrillo Chrome proxy resolver

This uses the new proxy resolution code in libbrillo for doing proxy
resolution rather than making the D-Bus calls directly through the
generated bindings. The unittest for this class was removed since the
main function of it was removed. It now is essentially just a wrapper
around the call into libbrillo along with some minimal code for
allowing cancelling of callbacks.

BUG= chromium:771386 
TEST=Unit tests pass

Change-Id: Ib0d4e413482f4bdfe0e9689f68118efbec94ec9d
Reviewed-on: https://chromium-review.googlesource.com/698964
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/real_system_state.h
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/real_system_state.cc
[delete] https://crrev.com/d7da8f4118c10d00d02b6274edd2f88971a6cb22/dbus_bindings/org.chromium.NetworkProxyService.dbus-xml
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/update_attempter_unittest.cc
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/chrome_browser_proxy_resolver.cc
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/Android.mk
[delete] https://crrev.com/d7da8f4118c10d00d02b6274edd2f88971a6cb22/chrome_browser_proxy_resolver_unittest.cc
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/chrome_browser_proxy_resolver.h
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/update_engine.gyp
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/update_attempter.h
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/fake_system_state.cc
[modify] https://crrev.com/cf5f1f1420b472477317b0ea0fa7f6456d2605cf/update_attempter.cc

Comment 2 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 3 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment