New issue
Advanced search Search tips

Issue 771379 link

Starred by 1 user
Status: Started
Owner:
steimel@chromium.org
Cc:
beccahughes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on: View detail
issue 752658
issue 776353
issue 871188


Sign in to add a comment

Handle remaining edge cases in LayoutMedia::ComputePanelWidth

Project Member Reported by steimel@chromium.org, Oct 3 2017 
There are a couple TODOs left in LayoutMedia::ComputePanelWidth that have to do with assuming the video is in the main frame and assuming the panel starts at the bottom left corner
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ed00d6eebad5fd8afc11d0e51ea3c7ee371754

commit 94ed00d6eebad5fd8afc11d0e51ea3c7ee371754
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Oct 06 20:41:28 2017

Don't cut off the media controls panel when in a scrollable iframe

Bug: 771379
Change-Id: I5865f8578794fdf46ad96217770f78edf23d9fc6
Reviewed-on: https://chromium-review.googlesource.com/701498
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507170}
[add] https://crrev.com/94ed00d6eebad5fd8afc11d0e51ea3c7ee371754/third_party/WebKit/LayoutTests/media/controls/video-in-scrollable-iframe-has-full-panel.html
[modify] https://crrev.com/94ed00d6eebad5fd8afc11d0e51ea3c7ee371754/third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Comment 2 by steimel@chromium.org, Nov 9 2017

Blockedon: 752658 776353

Comment 3 by steimel@chromium.org, Aug 9

Blockedon: 871188
►

Sign in to add a comment