New issue
Advanced search Search tips

Issue 771376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

[WPT Export] Cannot find 'current_revision' in Gerrit response

Project Member Reported by robertma@chromium.org, Oct 3 2017

Issue description

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/696493 is currently in the search results, but is empty (404 when trying to open the URL, probably deleted?).
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1074d4a1ba82e26838be1fc2fc4c5b88e982d633

commit 1074d4a1ba82e26838be1fc2fc4c5b88e982d633
Author: Robert Ma <robertma@chromium.org>
Date: Tue Oct 03 22:55:25 2017

Consider empty CL not exportable and do not throw

CLs returned by Gerrit search API might be empty (deleted), in which
case there is no revision and we should just ignore them.

Bug:  771376 
Change-Id: I45462955e2a845991adcbdb938cb15ed2509a392
Reviewed-on: https://chromium-review.googlesource.com/699352
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506218}
[modify] https://crrev.com/1074d4a1ba82e26838be1fc2fc4c5b88e982d633/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
[modify] https://crrev.com/1074d4a1ba82e26838be1fc2fc4c5b88e982d633/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment