Fix lint errors/warnings for Debian and RPM packages |
|||
Issue descriptionLintian (debian package linter) and rpmlint currently report several issues with our packages. We should fix them. lintian: E: chromium-browser-stable: debian-changelog-file-missing-or-wrong-name W: chromium-browser-stable: new-package-should-close-itp-bug W: chromium-browser-stable: debian-changelog-line-too-long line 3 E: chromium-browser-stable: no-copyright-file W: chromium-browser-stable: description-synopsis-starts-with-article W: chromium-browser-stable: extended-description-line-too-long W: chromium-browser-stable: package-contains-timestamped-gzip usr/share/doc/chromium-browser-stable/changelog.gz E: chromium-browser-stable: manpage-not-compressed usr/share/man/man1/chromium-browser.1 W: chromium-browser-stable: manpage-has-errors-from-man usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined W: chromium-browser-stable: binary-without-manpage usr/bin/chromium-browser-stable E: chromium-browser-stable: prerm-calls-updatemenus rpmlint: chromium-browser-stable.x86_64: W: manpage-not-compressed bz2 /usr/share/man/man1/chromium-browser.1 chromium-browser-stable.x86_64: E: explicit-lib-dependency zlib chromium-browser-stable.x86_64: W: spelling-error %description -l en_US org -> or, orig, orgy chromium-browser-stable.x86_64: E: description-line-too-long C Chromium is a browser that combines a minimal design with sophisticated technology to make the web faster, safer, and easier. chromium-browser-stable.x86_64: E: no-changelogname-tag chromium-browser-stable.x86_64: W: invalid-license Multiple, see http://www.chromium.org/ chromium-browser-stable.x86_64: W: executable-stack /opt/chromium.org/chromium/nacl_irt_x86_64.nexe chromium-browser-stable.x86_64: E: missing-call-to-chdir-with-chroot /opt/chromium.org/chromium/nacl_helper chromium-browser-stable.x86_64: E: missing-call-to-chdir-with-chroot /opt/chromium.org/chromium/chrome chromium-browser-stable.x86_64: E: missing-call-to-setgroups-before-setuid /opt/chromium.org/chromium/chrome-sandbox chromium-browser-stable.x86_64: E: missing-call-to-chdir-with-chroot /opt/chromium.org/chromium/chrome-sandbox chromium-browser-stable.x86_64: W: manual-page-warning /usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined chromium-browser-stable.x86_64: W: symlink-should-be-relative /usr/bin/chromium-browser-stable /opt/chromium.org/chromium/chromium-browser chromium-browser-stable.x86_64: W: no-manual-page-for-binary google-chrome chromium-browser-stable.x86_64: W: no-manual-page-for-binary chromium-browser-stable chromium-browser-stable.x86_64: W: percent-in-%post chromium-browser-stable.x86_64: W: dangerous-command-in-%post mv chromium-browser-stable.x86_64: E: use-tmp-in-%post chromium-browser-stable.x86_64: W: percent-in-%preun chromium-browser-stable.x86_64: W: dangerous-command-in-%preun rpm chromium-browser-stable.x86_64: E: use-tmp-in-%preun chromium-browser-stable.x86_64: W: desktopfile-without-binary /usr/share/applications/chromium-browser.desktop /usr/bin/chromium-browser-stable
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f1ac3735dace9ee652ef51a68102924500e0408 commit 7f1ac3735dace9ee652ef51a68102924500e0408 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Oct 04 19:26:36 2017 Linux packager: Various manpage fixes This CL: * Fixes some manpage syntax. * Compresses the manpages. * Adds manpage entries for google-chrome-stable and google-chrome for the stable channel. * Fixes a reference to google-chrome in the RPM spec. * Handles rpmlint suppressions using a conf file instead of just filtering out what we don't want. This fixes the following lint errors: * lintian: * E: chromium-browser-stable: manpage-not-compressed usr/share/man/man1/chromium-browser.1 * W: chromium-browser-stable: manpage-has-errors-from-man usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * rpmlint: * chromium-browser-stable.x86_64: W: manpage-not-compressed bz2 /usr/share/man/man1/chromium-browser.1 * chromium-browser-stable.x86_64: W: manual-page-warning /usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * chromium-browser-stable.x86_64: W: no-manual-page-for-binary google-chrome * chromium-browser-stable.x86_64: W: no-manual-page-for-binary chromium-browser-stable BUG=771373 R=thestig@chromium.org Change-Id: I5d1921150945123b72b5f2a50714c3094a526648 Reviewed-on: https://chromium-review.googlesource.com/699855 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506477} [modify] https://crrev.com/7f1ac3735dace9ee652ef51a68102924500e0408/chrome/app/resources/manpage.1.in [modify] https://crrev.com/7f1ac3735dace9ee652ef51a68102924500e0408/chrome/installer/linux/common/installer.include [modify] https://crrev.com/7f1ac3735dace9ee652ef51a68102924500e0408/chrome/installer/linux/rpm/chrome.spec.template [modify] https://crrev.com/7f1ac3735dace9ee652ef51a68102924500e0408/chrome/installer/linux/rpm/lint_package.py [add] https://crrev.com/7f1ac3735dace9ee652ef51a68102924500e0408/chrome/installer/linux/rpm/rpmlint.conf
,
Oct 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 3 2017