New issue
Advanced search Search tips

Issue 771368 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 771156
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

smoothness.tough_path_rendering_cases failing on 10 builders

Project Member Reported by martiniss@chromium.org, Oct 3 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2aea62a0bb0d916487158359dbd136b2bfa6880

commit b2aea62a0bb0d916487158359dbd136b2bfa6880
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue Oct 03 23:33:51 2017

//tools/perf: Disable story on smoothness benchmark

TBR=rnephew

Bug:  771368 
Change-Id: Ic194b890084702105f00b9246b1971f9062dbf2f
Reviewed-on: https://chromium-review.googlesource.com/699312
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506228}
[modify] https://crrev.com/b2aea62a0bb0d916487158359dbd136b2bfa6880/tools/perf/benchmarks/smoothness.py

Can repro the crash in Canary/Win here: https://bugs.chromium.org/p/chromium/issues/detail?id=771614
Owner: khushals...@chromium.org
The cause seems to be https://chromium.googlesource.com/chromium/src/+/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa.

When this is fixed, pls work with the speed team on reenabling these tests. Thanks!
The root cause is the same as 771156. Since the change was reverted, and I'll make sure to fix it before re-landing, I'll re enable the test.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426380cbae5736351fbf0d3928196cc2a29874f0

commit 426380cbae5736351fbf0d3928196cc2a29874f0
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Oct 05 03:56:31 2017

Revert "//tools/perf: Disable story on smoothness benchmark"

This reverts commit b2aea62a0bb0d916487158359dbd136b2bfa6880.

Reason for revert: The offending change has been reverted on https://chromium-review.googlesource.com/c/chromium/src/+/699755.

Original change's description:
> //tools/perf: Disable story on smoothness benchmark
> 
> TBR=rnephew
> 
> Bug:  771368 
> Change-Id: Ic194b890084702105f00b9246b1971f9062dbf2f
> Reviewed-on: https://chromium-review.googlesource.com/699312
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506228}

TBR=rnephew@chromium.org,martiniss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  771368 
Change-Id: I3de10e67b4ab36c08d1a82ab4e8fcef226295037
Reviewed-on: https://chromium-review.googlesource.com/701316
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506637}
[modify] https://crrev.com/426380cbae5736351fbf0d3928196cc2a29874f0/tools/perf/benchmarks/smoothness.py

Mergedinto: 771156
Status: Duplicate (was: Assigned)
Thanks!

Sign in to add a comment