New issue
Advanced search Search tips

Issue 771344 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Verify that we do not mistakenly run content-verification in any extensions/ browser_tests

Project Member Reported by proberge@chromium.org, Oct 3 2017

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/692554 we are enabling strict extension content verification for the Chromium testing config. In theory, this should not create failures since the official Chrome trybots have had strict extension content verification for a while.

We should monitor test failures to ensure that we didn't cause any test flakiness. For example, a test taking longer than usual could give time for content verification to finish and disable the extension being tested. 

 

Comment 1 by sczs@chromium.org, Oct 4 2017

Labels: -OS-iOS
Status: Assigned (was: Untriaged)
[Extensions Triage] Marking as Assigned.
Found and fixed a browser test: https://chromium-review.googlesource.com/c/chromium/src/+/705921

The browser test passed when I tried submitting the second reland. It failed on future builds, which suggests flaky behavior.

I looked for other instances of "good.crx". There's a few other cases where flakes could occur depending on whether they try to install the extension.

chrome/browser/chromeos/policy/device_local_account_browsertest.cc
chrome/browser/extensions/startup_helper_browsertest.cc

Status: Fixed (was: Assigned)
We would probably have detected any flakes by now

Sign in to add a comment