New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771342 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 771341
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

TKO parser doesn't like network_WiFi_{AttenuatedPerf,Perf} throughput results

Project Member Reported by briannorris@chromium.org, Oct 3 2017

Issue description

In looking at new keyval entries in the context of this CL:

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/695707

We noticed that our existing keyval files for network_WiFi_AttenuatedPerf (and probably network_WiFi_Perf too) aren't getting parsed correctly. e.g.:

https://storage.cloud.google.com/chromeos-autotest-results/146402154-chromeos-test/chromeos1-grover-host9/.parse.log?_ga=2.41266402.-1746072600.1506638659

complains about:

...tko parser: WARNING: line "ch001_modeHT40p_none_tcp_tx_atten066_throughput{perf}=143.91+-3.92" found in test iteration keyval could not be parsed
...

This code is looking for 'float', not for 'float+-float'

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/tko/parsers/version_1.py#100

        # Parse the actual value into a dict.
        try:
            if val_type == 'attr':
                attr_dict[key] = value
            elif val_type == 'perf':
                perf_dict[key] = float(value)
            else:
                raise ValueError
        except ValueError:
            msg = ('WARNING: line "%s" found in test '
                   'iteration keyval could not be parsed')


We should either improve the parser to handle +- (just drop the error bar, and report the mean netperf result?) or modify the keyval output in these tests, so it's parseable.

Any thoughts? I'd kinda lean toward the former, since the error bars are useful in some other contexts (mostly manual inspection, so far).
 

Comment 1 Deleted

Mergedinto: 771341
Status: Duplicate (was: Untriaged)
Oops, didn't notice this submitted twice...

Sign in to add a comment