Issue metadata
Sign in to add a comment
|
[meta] Rethink WebContentsObserver::DidReceiveCompositorFrame |
||||||||||||||||||||||
Issue descriptionSince CompositorFrames will go to a different process this content API should ideally not exist at all. Alternatively we maybe need a viz host hook that tells us when a given client submits a new CompositorFrame. This is likely going to be expensive so I recommend auditing all uses of WebContentsObserver::DidReceiveCompositorFrame and rethinking them.
,
Oct 3 2017
Ahh then we should replace this with a viz test interface, if that's the case. +jonross@ as he's been thinking about tests.
,
Oct 3 2017
piman@ is right. I added this method to be able to notify FrameWatcher (tests only) and DevTools when a CompositorFrame arrives(CL: https://codereview.chromium.org/2780373002/). I think decoupling content-related fields from CompositorFrameMetadata might automatically solve this issue, because I think those are the only fields that FrameWatcher and DevTools look into.
,
Oct 12 2017
,
Feb 9 2018
Issue 791024 has been merged into this issue.
,
Feb 9 2018
From the merged bug, this used by: browser_test_utils::FrameWatcher DevToolsEyeDropper RenderFrameDevToolsAgentHost HeadlessWebContentsImpl
,
Feb 9 2018
I plan to kill FrameWatcher when I unify our 4? test apis for listening to frame submission. The others can likely also make use of the RenderFrameMetadata observing.
,
May 11 2018
The only usages of DidReceiveCompositorFrame are in DevToolsEyeDropper and RenderFrameDevToolsAgentHost. Assigning to myself so I can get rid of this method after the old DevTools code paths for video capture is gone.
,
Jul 30
The NextAction date has arrived: 2018-07-30
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9 commit 5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9 Author: Saman Sami <samans@chromium.org> Date: Wed Aug 08 12:12:25 2018 Remove UseVideoCaptureApiForDevToolsSnapshots feature This feature is on in M68, and M69 also has this switch just in case. Remove it in M70. Bug: 813929 , 771337 Change-Id: Id411c324a136bc7321912e2dac6f2eb5ca0892ca Reviewed-on: https://chromium-review.googlesource.com/1162265 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#581525} [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/devtools_frame_trace_recorder.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/devtools_frame_trace_recorder.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/renderer_host/render_widget_host_delegate.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/browser/web_contents_observer.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/common/content_features.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/common/content_features.h
,
Aug 8
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by piman@chromium.org
, Oct 3 2017