New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771336 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 813929
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 775030



Sign in to add a comment

Decouple DevTools from CompositorFrames

Project Member Reported by fsamuel@google.com, Oct 3 2017

Issue description

Devtools currently synchronously inspects CompositorFrameMetadata. We need to inspect why it does and come up with an async Viz-compatible way to do this.
 

Comment 1 by alph@chromium.org, Oct 10 2017

Owner: caseq@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fsamuel@google.com, Oct 16 2017

Blocking: 775030
Are you actively working on this? thanhph@ was thinking of picking this up.

Comment 3 by caseq@chromium.org, Oct 16 2017

Owner: thanhph@chromium.org
No, I'm not working on this at the moment, I guess I ended up being assignee because I've worked on screenshots in DevTools. Handing over to thanhph@, please feel free to ping me if you need any help on part of DevTools.

Comment 4 by caseq@chromium.org, Oct 16 2017

Cc: caseq@chromium.org

Comment 5 by fsamuel@google.com, Oct 24 2017

Any update on this?
Components: -Platform>DevTools

Comment 7 by danakj@chromium.org, Dec 14 2017

Owner: ----
Status: Available (was: Assigned)
Blocking: -730193
Cc: sundarrajs@google.com
Components: Internals>Services>Viz
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0

commit 2acabd1217dd8ca92fb3269e7be7619ef77ca5a0
Author: Saman Sami <samans@chromium.org>
Date: Sat Mar 10 00:51:09 2018

Use FrameSinkVideoCapturer in DevTools eyedropper tool

The eyedropper tool currently depends on being notified about arrival
of CompositorFrames from the renderer which is incompatible with the
VizDisplayCompositor feature. If viz is enabled, use the new video
capture API with is compatible with viz.

TBR=jam@chromium.org

Bug:  771336 
Change-Id: I3e0edaf9cc467045a00fa05212ce79cfd58065c9
Reviewed-on: https://chromium-review.googlesource.com/949885
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542299}
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/chrome/browser/DEPS
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/chrome/browser/devtools/devtools_eye_dropper.cc
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/chrome/browser/devtools/devtools_eye_dropper.h
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/2acabd1217dd8ca92fb3269e7be7619ef77ca5a0/content/public/browser/render_widget_host_view.h

Owner: jonr...@chromium.org
Mergedinto: 813929
Status: Duplicate (was: Available)
We have already implemented a new code path that doesn't rely on CompositorFrameMetadata. I just need to remove the old code path once we hit stable.

Sign in to add a comment