New issue
Advanced search Search tips

Issue 771329 link

Starred by 1 user
Status: Fixed
Owner:
majidvp@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Missing CheckAlignment call in TransformationMatrix(const SkMatrix44& matrix)

Project Member Reported by brucedaw...@chromium.org, Oct 3 2017 
While looking at  crbug.com/770574  I noticed that all TransformationMatrix constructors except for one included a call to CheckAlignment. That one constructor with the missing call was added in https://codereview.chromium.org/1602343002.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8bd3bd533077b6eafabe67e62b5bdee7a502be3

commit f8bd3bd533077b6eafabe67e62b5bdee7a502be3
Author: Majid Valipour <majidvp@chromium.org>
Date: Thu Oct 12 23:33:46 2017

Add alignment check to TransformationMatrix SkMatrix44 constructor 

Bug:  771329 
Change-Id: I9585afb60639174f5d5e840da3c958f310ff5a60
Reviewed-on: https://chromium-review.googlesource.com/709457
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508538}
[modify] https://crrev.com/f8bd3bd533077b6eafabe67e62b5bdee7a502be3/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h

Comment 2 by majidvp@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment