Issue metadata
Sign in to add a comment
|
[MacViewsBrowser] Restore TaskManager to native Cocoa version in MacViewsBrowser |
||||||||||||||||||||||
Issue descriptionCurrently the TaskManager appearing in MacViewsBrowser builds is the Views version, not the native Cocoa version. We can't ship with the Views Task manager as it is, and fixing it will take a lot of work. Instead of holding up shipping MacViewsBrowser we should decouple the Task Manager and allow MVB and the Views Task Manager to ship when each is ready. -> ellyjones@ for assignment.
,
Oct 3 2017
> I thought there was a lot about default sort order and subframe processes that was fixed in the Views version. I'm not sure about that (that may all be true), but the Views Task Manager tableview is very rough and not Mac like at all. We can't ship it on the Mac the way it works today, and it will take a lot of work to fix it. If we do decide to switch over to it it's best to leave that work for post-Views top chrome.
,
Oct 4 2017
Ok, if it's not the one that's enabled by default, then maybe I've got my terminology mixed up. I'll confirm with Nick and Avi.
,
Oct 4 2017
I'm not going to work on this soon so I'm tagging it M-X; I'll look at that again in two weeks.
,
Oct 4 2017
When you build MacViews you get the Views Task Manager. I know because I built in Views and enabled both Views and Cocoa Task Managers simultaneously during my Cocoa Task Manager task work. To switch is a few lines of code.
,
Oct 4 2017
creis@1: The cocoa task manager is still built on top of the TaskManagerTableModel (thanks to avi's work a while back), so it should display the same columns in the same order as the views TaskManager. However, we'll need to do a little more fixing-up to get my selection-consistency modifications working properly in the cocoa TaskManagerMac. Shouldn't be hard -- it'll be similar to the existing reloadDataWithRows.
,
Oct 4 2017
Hooray! Sounds Avi's earlier work resolved my concerns. Thanks!
,
Oct 11 2017
,
Oct 11 2017
Elly's made a start in https://chromium-review.googlesource.com/c/chromium/src/+/714041
,
Oct 12 2017
Oops - I didn't think ellyjones@ was working on it. Switching back.
,
Oct 16 2017
The NextAction date has arrived: 2017-10-16
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84 commit 67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Oct 23 07:48:33 2017 macviews: enable cocoa task manager in views browser This change: 1) Links task_manager_mac.mm and one of its dependencies into the views browser as well as the cocoa browser 2) Uses TaskManagerMac's versions of the task manager browser functions in views browser builds Bug: 771328 Change-Id: I7a9187bb402c4de219aeade3e6cf87ade776d413 Reviewed-on: https://chromium-review.googlesource.com/723260 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#510728} [modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc [modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/views/browser_dialogs_views.cc [modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/views/task_manager_view.cc
,
Oct 23 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by creis@chromium.org
, Oct 3 2017