New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771328 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-10-16
OS: Mac
Pri: 1
Type: Bug
M-X



Sign in to add a comment

[MacViewsBrowser] Restore TaskManager to native Cocoa version in MacViewsBrowser

Project Member Reported by shrike@chromium.org, Oct 3 2017

Issue description

Currently the TaskManager appearing in MacViewsBrowser builds is the Views version, not the native Cocoa version. We can't ship with the Views Task manager as it is, and fixing it will take a lot of work. Instead of holding up shipping MacViewsBrowser we should decouple the Task Manager and allow MVB and the Views Task Manager to ship when each is ready.

-> ellyjones@ for assignment.
 

Comment 1 by creis@chromium.org, Oct 3 2017

Cc: afakhry@chromium.org nick@chromium.org a...@chromium.org
Isn't the Cocoa task manager a large regression from the Mac Views one?  I thought there was a lot about default sort order and subframe processes that was fixed in the Views version.  Or am I thinking of something different?  (These things work on Mac today, and I don't think we should let them regress.)
> I thought there was a lot about default sort order and subframe processes that was fixed in the Views version.

I'm not sure about that (that may all be true), but the Views Task Manager tableview is very rough and not Mac like at all. We can't ship it on the Mac the way it works today, and it will take a lot of work to fix it. If we do decide to switch over to it it's best to leave that work for post-Views top chrome.

Comment 3 by creis@chromium.org, Oct 4 2017

Ok, if it's not the one that's enabled by default, then maybe I've got my terminology mixed up.  I'll confirm with Nick and Avi.
Labels: M-X
NextAction: 2017-10-16
Status: Assigned (was: Untriaged)
I'm not going to work on this soon so I'm tagging it M-X; I'll look at that again in two weeks.

Comment 5 by a...@chromium.org, Oct 4 2017

When you build MacViews you get the Views Task Manager. I know because I built in Views and enabled both Views and Cocoa Task Managers simultaneously during my Cocoa Task Manager task work.

To switch is a few lines of code.

Comment 6 by nick@chromium.org, Oct 4 2017

creis@1: The cocoa task manager is still built on top of the TaskManagerTableModel (thanks to avi's work a while back), so it should display the same columns in the same order as the views TaskManager.

However, we'll need to do a little more fixing-up to get my selection-consistency modifications working properly in the cocoa TaskManagerMac. Shouldn't be hard -- it'll be similar to the existing reloadDataWithRows.

Comment 7 by creis@chromium.org, Oct 4 2017

Hooray!  Sounds Avi's earlier work resolved my concerns.  Thanks!

Comment 8 by shrike@chromium.org, Oct 11 2017

Cc: ellyjo...@chromium.org
Owner: shrike@chromium.org
Status: Started (was: Assigned)
Cc: -ellyjo...@chromium.org shrike@chromium.org
Owner: ellyjo...@chromium.org
Oops - I didn't think ellyjones@ was working on it. Switching back.
The NextAction date has arrived: 2017-10-16
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84

commit 67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Oct 23 07:48:33 2017

macviews: enable cocoa task manager in views browser

This change:
1) Links task_manager_mac.mm and one of its dependencies into the views browser
   as well as the cocoa browser
2) Uses TaskManagerMac's versions of the task manager browser functions in
   views browser builds

Bug:  771328 
Change-Id: I7a9187bb402c4de219aeade3e6cf87ade776d413
Reviewed-on: https://chromium-review.googlesource.com/723260
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510728}
[modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/67fcbbe119c208dd2bdc0c7f63d47cd1ff95cd84/chrome/browser/ui/views/task_manager_view.cc

Status: Fixed (was: Started)

Sign in to add a comment