New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771325 link

Starred by 1 user
Status: Fixed
Owner:
jchin...@chromium.org
Closed: Nov 2017
Cc:
hinoka@chromium.org
█ iannucci@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: 7
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 774531
Blocking:
issue 468053



Sign in to add a comment

Add header section to Milo console view

Project Member Reported by efoo@chromium.org, Oct 3 2017 
Masters have “header” sections, which are defined by html templates in the build repo. Milo needs a mechanism to display the equivalent information, but not necessarily with the same syntax.

Known use cases:
1. https://chromium-build.appspot.com/p/chromium/console
   2 columns (1 text, 1 bubble)
2. https://build.chromium.org/p/client.v8/console
   3 columns (2 text, 1 bubble).  The 2 text columns are there to flow the header thinner

Design doc: 
https://docs.google.com/document/d/1yuSZzWIitZeJJdTssz94gWNtGLFR5ltGolkaBJNRbFM/edit#heading=h.3txmesynre6a

Comment 1 by efoo@chromium.org, Oct 3 2017

Description: Show this description

Comment 2 by efoo@chromium.org, Oct 3 2017

EstimatedDays: 7
Assigning estimated time to 7 days. Please update if inaccurate.

Comment 3 by efoo@chromium.org, Oct 3 2017

Blocking: 468053

Comment 4 by efoo@chromium.org, Oct 4 2017

Cc: -jchin...@chromium.org iannucci@chromium.org
Owner: jchin...@chromium.org
Re-assigned to Jao-ke since she's implementing this.

Comment 5 by efoo@chromium.org, Oct 7 2017

Labels: LUCI-Blocker-M4
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/406ebc7f72a6ef67063c4f4f75256bdc2a2b6c3b

commit 406ebc7f72a6ef67063c4f4f75256bdc2a2b6c3b
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Oct 10 07:38:16 2017

[milo] Add BuilderSummary and its update logic.

This is for the console header; see
https://docs.google.com/document/d/1yuSZzWIitZeJJdTssz94gWNtGLFR5ltGolkaBJNRbFM/edit?ts=59cafb59#heading=h.3txmesynre6a

This CL doesn't actually hook BuilderSummary in with build pubsub message receipt yet.

Bug:  771325 
Change-Id: Ib54f715a297d8306baaaa52eb92353c50791a9b5
Reviewed-on: https://chromium-review.googlesource.com/706553
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[add] https://crrev.com/406ebc7f72a6ef67063c4f4f75256bdc2a2b6c3b/milo/common/model/builder_summary.go
[add] https://crrev.com/406ebc7f72a6ef67063c4f4f75256bdc2a2b6c3b/milo/common/model/builder_summary_test.go

Comment 7 by hinoka@chromium.org, Oct 13 2017

Blockedon: 774531
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 16 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/c204034272f452cfb1fe03789aec8a413f88160b

commit c204034272f452cfb1fe03789aec8a413f88160b
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Oct 16 22:04:25 2017

Update luci-milo protos to match new proto format

The format changed here: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/714299
In order to conform to proto naming style.  This CL matches the proto
with the new format.

Bug:  771325 
Change-Id: I5856ce2254b64b4f28ad660a41a6554aaa4552fd
Reviewed-on: https://chromium-review.googlesource.com/721867
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/c204034272f452cfb1fe03789aec8a413f88160b/luci-milo.cfg
[modify] https://crrev.com/c204034272f452cfb1fe03789aec8a413f88160b/luci-milo-dev.cfg

Comment 10 by efoo@chromium.org, Oct 17 2017

Labels: LUCI-M3-S10
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0c7851c87946f2a267c065a26c92e9dbffd18e9b

commit 0c7851c87946f2a267c065a26c92e9dbffd18e9b
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Mon Oct 30 23:27:06 2017

[milo] Use BuildID, build creation time in BuilderSummary.

Previously BuilderSummary used BuildKey to reference builds, which is brittle; use BuildID instead.
Also, hold last completed build creation time within BuilderSummary to avoid needing to re-query.

Bug:  771325 
Change-Id: I7067293578812b76e779b91a32927d74cd532b35
Reviewed-on: https://chromium-review.googlesource.com/744732
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/0c7851c87946f2a267c065a26c92e9dbffd18e9b/milo/buildsource/buildbot/buildstore/build.go
[modify] https://crrev.com/0c7851c87946f2a267c065a26c92e9dbffd18e9b/milo/buildsource/buildbucket/pubsub.go
[modify] https://crrev.com/0c7851c87946f2a267c065a26c92e9dbffd18e9b/milo/common/model/build_summary.go
[modify] https://crrev.com/0c7851c87946f2a267c065a26c92e9dbffd18e9b/milo/common/model/builder_summary.go
[modify] https://crrev.com/0c7851c87946f2a267c065a26c92e9dbffd18e9b/milo/common/model/builder_summary_test.go
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/584fb63a193839e8e1548082cd4f06a99a95cf13

commit 584fb63a193839e8e1548082cd4f06a99a95cf13
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Thu Nov 02 09:31:56 2017

[milo] Populate console strings list in BuilderSummary.

BuildSummaries now store (temporarily, as the field does not get written
to datastore) the list of Consoles returned by GetAllConsoles. These, in
turn, get processed into lists of console strings in the BuilderSummary.

Also remove unnecessary datastore operations in builder_summary_test.go.

Bug:  771325 
Change-Id: I2d329abc394fa5989725f7274c1206c61cec2b5e
Reviewed-on: https://chromium-review.googlesource.com/750235
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/584fb63a193839e8e1548082cd4f06a99a95cf13/milo/common/model/build_summary.go
[modify] https://crrev.com/584fb63a193839e8e1548082cd4f06a99a95cf13/milo/common/model/builder_summary.go
[modify] https://crrev.com/584fb63a193839e8e1548082cd4f06a99a95cf13/milo/common/model/builder_summary_test.go

Comment 17 by efoo@chromium.org, Nov 7 2017

Labels: -REQBY-LUCI-M4-OpenBeta -LUCI-M3-ClosedBeta REQBY-LUCI-M4a-MacWinPOC LUCI-M3-Beta LUCI-M3-S11

Comment 18 by efoo@chromium.org, Nov 7 2017 

based on the update in foundation meeting, can we closed this?

Comment 19 by hinoka@chromium.org, Nov 7 2017 

Yeah i think we can close this.

Comment 20 by efoo@chromium.org, Nov 7 2017 

Hold on. Actually, don't close this until we move this from experimental to chromium. Once we do this, I think we can close.

Comment 21 by efoo@chromium.org, Nov 7 2017 

Also, fix missing Trooper and Sheriff due to different json schema.

Thanks!

Comment 23 by estaab@chromium.org, Nov 14 2017

Status: Fixed (was: Assigned)

Comment 24 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 25 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M3-Beta luci-blocker-migration

Comment 26 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets
►

Sign in to add a comment