New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771318 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Revert r145305

Project Member Reported by robho...@gmail.com, Oct 3 2017

Issue description

See https://bugs.webkit.org/show_bug.cgi?id=108357

I think this can be reverted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a2b7b75eeccbb4e06a5cf7faed637af7b6719a

commit 11a2b7b75eeccbb4e06a5cf7faed637af7b6719a
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Nov 06 22:28:46 2017

Remove unnecessary extra layout in table cells

This reverts https://chromium.googlesource.com/chromium/src/+/07b40911c8d2e3256f6dd54789e687f548bd9090

It introduced an extra layout that appears to be no longer necessary. 

LayoutNG inadvertently relies on the second layout to position the NG fragment correctly
inside the legacy layout containing block. This is because in legacy layout the inline position
for an object isn't calculated until after it has been laid out by its container. I've
made this a bug for now as I'm not sure if the right fix for it is straightforward.

Bug:  771318 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2f6fa970f630a59d96189712c7c25a93f98d0906
Reviewed-on: https://chromium-review.googlesource.com/698845
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514259}
[modify] https://crrev.com/11a2b7b75eeccbb4e06a5cf7faed637af7b6719a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/11a2b7b75eeccbb4e06a5cf7faed637af7b6719a/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
[modify] https://crrev.com/11a2b7b75eeccbb4e06a5cf7faed637af7b6719a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Comment 2 by robho...@gmail.com, Dec 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment