New issue
Advanced search Search tips

Issue 771314 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
nightlight



Sign in to add a comment

Night Light slider knobs are mis-positioned when display settings is first opened

Project Member Reported by afakhry@chromium.org, Oct 3 2017

Issue description

When chrome://settings/display is opened for the first time after login, both knobs are incorrectly positioned on the left side of the slider [see attachment].
 
Selection_043.png
14.1 KB View Download
Labels: M-63
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/563c9a60addad992cba2b8963011035c9237b553

commit 563c9a60addad992cba2b8963011035c9237b553
Author: Ahmed Fakhry <afakhry@google.com>
Date: Wed Oct 04 01:02:55 2017

Night Light: Fix slider knobs positions on first loading of the page

When the Display settings page is opened for the first time after login,
both knobs are incorrectly positioned on the left side of the slider.
Use this.async to update the knob after the element has attached, and
rename customTimesChanged_() to updateKnobs_() for better readablility.

BUG= 771314 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifed0da5c45bf488c4d179deddb0fb36d0d1690c7
Reviewed-on: https://chromium-review.googlesource.com/698765
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506258}
[modify] https://crrev.com/563c9a60addad992cba2b8963011035c9237b553/chrome/browser/resources/settings/device_page/night_light_slider.html
[modify] https://crrev.com/563c9a60addad992cba2b8963011035c9237b553/chrome/browser/resources/settings/device_page/night_light_slider.js

Status: Fixed (was: Started)
 Issue 771131  has been merged into this issue.

Sign in to add a comment