New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771311 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Shelf icon resolution is not right

Project Member Reported by warx@chromium.org, Oct 3 2017

Issue description

See the screenshot on caroline device

Chrome 63.0.3232.0

+shelf/ owners
 
Screenshot 2017-10-03 at 12.57.53.png
953 KB View Download

Comment 1 by msw@chromium.org, Oct 3 2017

Labels: Needs-Feedback
Can you test if adding/enabling this flag fixes the defect?

--ash-disable-shelf-model-synchronization
  "Disable shelf model synchronization" (in about:flags)

Comment 2 by warx@chromium.org, Oct 3 2017

Labels: -Needs-Feedback
enabling this flag fixes the problem

Comment 3 by msw@chromium.org, Oct 3 2017

Owner: msw@chromium.org
Status: Started (was: Untriaged)
Thanks, I'll take a look. ShelfModel sync probably only passes 1x bitmaps.

Comment 4 by msw@chromium.org, Oct 3 2017

I can repro on linux desktop with --ash-host-window-bounds=1000x1000*2
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd29d0be03411ad61bc6902ddd8355caf865ab7

commit 9fd29d0be03411ad61bc6902ddd8355caf865ab7
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Oct 05 04:54:26 2017

Ash: Use HiDPI shelf icons and menu item images.

Replace 1x SkBitmaps in shelf mojo structs with ImageSkia.
Fixes shelf item icons and icons in application menus.

Revise unit tests to support the new handle-bearing struct.
(add a test service to echo ShelfItem for struct traits)

Bug:  655874 ,  771311 
Test: Shelf icons look good with --ash-host-window-bounds=1000x1000*2
Change-Id: I646b9c3f5cdb1aac1413a26f166e401968cec865
Reviewed-on: https://chromium-review.googlesource.com/699417
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506655}
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/OWNERS
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/shelf_struct_traits.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/shelf_struct_traits.h
[add] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/shelf_struct_traits_test_service.mojom
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/cpp/shelf_struct_traits_unittest.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/interfaces/shelf.mojom
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/public/interfaces/shelf.typemap
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/shelf/shelf_application_menu_model.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ash/shelf/shelf_context_menu_model.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc
[modify] https://crrev.com/9fd29d0be03411ad61bc6902ddd8355caf865ab7/ui/gfx/image/mojo/image_traits_unittest.cc

Comment 6 by msw@chromium.org, Oct 5 2017

Status: Fixed (was: Started)
This should be fixed, please help verify, thanks!
I'll separately look into shelf image transport frequency/efficiency.

Comment 7 by warx@chromium.org, Oct 6 2017

Status: Verified (was: Fixed)
63.0.3234.0

Sign in to add a comment