omnibox text fades then disappears as you scroll to the right in omnibox text field in iOS11.1 beta |
||||||||||||||
Issue descriptionApp Version:63.0.3224.3 iOS Version: iOS11.1 beta ONLY Device: iPhone 6s plus URL: GWS SRP Steps to reproduce: 1. Type a query in omnibox 2. Once on SRP tap on the omnibox, then start to drag cursor to the right past the current last letter, to reveal the rest of the URL Observed results: As you drag to the right notice that the characters fade, eventually invisible. Expected results: All characters should remain visible as you drag the cursor to the right Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Observed behavior in Chrome Mobile on Android: n/a Check for similar behavior on Firefox/Safari: n/a Bug reproducible on current stable build (App Version, iOS Version): Not so far in my testing... Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes on Beta M62 screenshot ios11.1 beta: https://drive.google.com/file/d/0By4O1f2IQqQ_bGNyTWhPRVpuU2M/view
,
Oct 3 2017
,
Oct 4 2017
Review for this bug is time sensitive due to it being iOS11.1Beta only. To those cc'ed here: please triage this as to who you think is the best owner so that we can determine if this should affect plans for M62 asap.
,
Oct 4 2017
stkhapugin@ could you PTAL.
,
Oct 5 2017
,
Oct 5 2017
This is pretty bad, at least something needs to be done for 62 (because it's likely that 62 will ship around the same time as 11.1)
,
Oct 5 2017
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/386b9b2dad021739ef321fa485a54238586bc658 commit 386b9b2dad021739ef321fa485a54238586bc658 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Oct 06 13:40:22 2017 Disable fading text in omnibox on iOS 11.1. A bug in iOS 11 broke the omnibox most significant part of the URL display mechanism; and in response to the radar in 11.1 the "fix" is changing the way drawTextInRect: operates - now it just ignores its argument. This causes issues with omnibox that is overriding this method in order to mask out the clipped prefix/suffix with a fade effect and to display the most significant part of the URL: the URL now cannot be cut the way we want, so the fade effect obscures useful text in the omnibox instead This CL just disables this custom behavior on 11.1. Bug: 771248 Change-Id: I9628adf195c3cbec36b962d2f872f658ad960529 Reviewed-on: https://chromium-review.googlesource.com/704638 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#507046} [modify] https://crrev.com/386b9b2dad021739ef321fa485a54238586bc658/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
,
Oct 6 2017
Please verify if the issue is fixed now so that I can request a cherry-pick to 62. Related bug that tracks the ellipsis on iOS 11: crbug.com/749788
,
Oct 6 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 10 2017
Verified on chrome canary version 63.0.3237.0 on iPhone 6 plus with iOS 11.1 Beta, following the steps mentioned in comment #0, omnibox characters do not fade and are visible on moving the cursor from left to right. Looks good.
,
Oct 10 2017
,
Oct 10 2017
Thanks vbarigela! Requesting merge. The change is low-risk, because we're just disabling code on iOS 11.1 that was already disabled on iOS 11.0 due to an iOS API bug/change.
,
Oct 10 2017
This bug requires manual review: Less than 3 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10 2017
,
Oct 12 2017
Has this been merged into 62?
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecec8cdd5559b8a6ad77a7de13732a4c9ee9e39c commit ecec8cdd5559b8a6ad77a7de13732a4c9ee9e39c Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Oct 13 11:05:29 2017 Disable fading text in omnibox on iOS 11.1. A bug in iOS 11 broke the omnibox most significant part of the URL display mechanism; and in response to the radar in 11.1 the "fix" is changing the way drawTextInRect: operates - now it just ignores its argument. This causes issues with omnibox that is overriding this method in order to mask out the clipped prefix/suffix with a fade effect and to display the most significant part of the URL: the URL now cannot be cut the way we want, so the fade effect obscures useful text in the omnibox instead This CL just disables this custom behavior on 11.1. Bug: 771248 Change-Id: I9628adf195c3cbec36b962d2f872f658ad960529 Reviewed-on: https://chromium-review.googlesource.com/704638 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#507046}(cherry picked from commit 386b9b2dad021739ef321fa485a54238586bc658) Reviewed-on: https://chromium-review.googlesource.com/718357 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#679} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ecec8cdd5559b8a6ad77a7de13732a4c9ee9e39c/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
,
Oct 13 2017
lindsayw: sorry, I was confused with gerrit's UI and was convinced I've cherry-picked two days ago, when in reality I only cherry-picked just now.
,
Oct 13 2017
Verified fix for the issue "omnibox text fades then disappears as you scroll to the right in omnibox text field in iOS11.1 beta" Build - 62.0.3202.56 Beta Devices -iPhone 6 plus, iPhone 8 plus, iPhone 8, iPhone 6, iPad mini iOS - 11.1 beta, 11.0.2 , 11.0.3 |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by linds...@chromium.org
, Oct 3 2017