New issue
Advanced search Search tips

Issue 771223 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 768923



Sign in to add a comment

WebVR: Remove unshipped http overlay

Project Member Reported by mthiesse@chromium.org, Oct 3 2017

Issue description

The insecure origin overlay that appears when WebVR presentation is begun on insecure origins has not shipped, and will never ship, as WebVR 2.0 will restrict presentation to secure origins.

This overlay is currently reachable through the enable_webvr flag which bypasses the origin trial, meaning it is possible to reach if users flip a flag (but it is off by default).

We would like to remove it for code simplification and to avoid avoid having to maintain it through our refactoring efforts.
 
Blocking: 768923
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8

commit ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Oct 05 16:50:12 2017

VR: Remove insecure content warning WebVR overlay.

The insecure content warning WebVR overlay is (virtually) unused, and
causing maintenance overhead. It will never ship, so we should just
remove it.

Bug:  771223 
Change-Id: I852e5bed6954606b894955fce71942b5e19dc3f0
Reviewed-on: https://chromium-review.googlesource.com/698276
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506767}
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/browser_ui_interface.h
[delete] https://crrev.com/257e2b62f62497383b971b6c8ba6da5bc369de4c/chrome/browser/vr/elements/insecure_content_permanent_texture.cc
[delete] https://crrev.com/257e2b62f62497383b971b6c8ba6da5bc369de4c/chrome/browser/vr/elements/insecure_content_permanent_texture.h
[delete] https://crrev.com/257e2b62f62497383b971b6c8ba6da5bc369de4c/chrome/browser/vr/elements/insecure_content_transient_texture.cc
[delete] https://crrev.com/257e2b62f62497383b971b6c8ba6da5bc369de4c/chrome/browser/vr/elements/insecure_content_transient_texture.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/elements/simple_textured_element.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/ui.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/ui.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/ab056206f7bb95e81ce9ce62cfc2f3eebb8666c8/components/page_info_strings.grdp

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in Chrome Dev 63.0.3236.6. Both overlays are absent now:
- "Not secure"
- "Your connection to this site is not private. ..."
Labels: -Restrict-View-Google
Components: Blink>WebXR

Sign in to add a comment