New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Hotlist-MemoryInfra



Sign in to add a comment

Memory.Experimental.Gpu2.CommandBuffer is skipped on Svelte

Project Member Reported by ericrk@chromium.org, Oct 3 2017

Issue description

Because the GPU proc is folded into the browser proc on Svelte, we don't log the Memory.experimental.Gpu2.CommandBuffer value. We should probably detect in-proc GPU and log some of these metrics for the browser proc. See code here: https://cs.chromium.org/chromium/src/chrome/browser/metrics/process_memory_metrics_emitter.cc?rcl=b18507453f5b27f871d1f72e7d96d88ec2f82711&l=279
 
Owner: cblume@chromium.org
Status: Assigned (was: Available)
Chris, can you take a look at this? Feel free to ping me for more information. This should be pretty straightforward. We want to emit a subset of GPU proc memory metrics in the Browser proc when running with the GPU process folded into the browser process.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ebf0347cd84eff25ef685acb62d6920618d87e

commit 24ebf0347cd84eff25ef685acb62d6920618d87e
Author: Chris Blume <cblume@google.com>
Date: Wed Nov 08 22:21:23 2017

Log CommandBuffer memory in Svelte

Because there is no separate GPU process in Svelte, GPU memory usage is
not reported. This includes the CommandBuffer memory. But the
CommandBuffer is still being used. So we should report that memory usage
when the GPU process is bundled into the browser process.

BUG= 771221 

Change-Id: I64dee042f920ef845c226e937617f32ecce8e9b4
Reviewed-on: https://chromium-review.googlesource.com/757686
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514970}
[modify] https://crrev.com/24ebf0347cd84eff25ef685acb62d6920618d87e/chrome/browser/metrics/process_memory_metrics_emitter.cc

Status: Fixed (was: Assigned)

Sign in to add a comment