New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Compiler error: pixel_test.cc

Project Member Reported by khorimoto@chromium.org, Oct 3 2017

Issue description

Build broken. Seems to be caused by either:
https://chromium-review.googlesource.com/c/chromium/src/+/693617
  or
https://chromium-review.googlesource.com/c/chromium/src/+/695907

Build error below:

../../cc/test/pixel_test.cc:183:17: error: no member named 'enable_color_correct_rasterization' in 'cc::LayerTreeSettings'; did you mean 'enable_oop_rasterization'?
      settings_.enable_color_correct_rasterization,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                enable_oop_rasterization
../../cc/trees/layer_tree_settings.h:145:8: note: 'enable_oop_rasterization' declared here
  bool enable_oop_rasterization = false;
       ^
In file included from ../../cc/test/pixel_test.cc:5:
In file included from ../../cc/test/pixel_test.h:5:
In file included from ../../base/files/file_util.h:15:
In file included from ../../buildtools/third_party/libc++/trunk/include/set:389:
In file included from ../../buildtools/third_party/libc++/trunk/include/__tree:16:
../../buildtools/third_party/libc++/trunk/include/memory:3065:32: error: no matching constructor for initialization of 'cc::LayerTreeResourceProvider'
    return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...));
                               ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../cc/test/pixel_test.cc:180:35: note: in instantiation of function template specialization 'std::__1::make_unique<cc::LayerTreeResourceProvider, cc::TestInProcessContextProvider *, cc::TestSharedBitmapManager *, viz::TestGpuMemoryBufferManager *, bool, bool &, viz::ResourceSettings &>' requested here
  child_resource_provider_ = std::make_unique<LayerTreeResourceProvider>(
                                  ^
../../cc/resources/layer_tree_resource_provider.h:20:3: note: candidate constructor not viable: requires 5 arguments, but 6 were provided
  LayerTreeResourceProvider(
  ^
../../cc/resources/layer_tree_resource_provider.h:78:28: note: candidate constructor not viable: requires 1 argument, but 6 were provided
  DISALLOW_COPY_AND_ASSIGN(LayerTreeResourceProvider);
                           ^
2 errors generated.
[877/17898] CXX obj/ui/gl/gl_unittest_utils/gl_mock.o
ninja: build stopped: subcommand failed.

 
Owner: ccameron@chromium.org
That's https://chromium-review.googlesource.com/c/chromium/src/+/695907
There are 2 reverts in flight:
https://chromium-review.googlesource.com/c/chromium/src/+/698285
https://chromium-review.googlesource.com/c/chromium/src/+/698286

The first one of them looks to have landed. I'll leave this open for a moment to see how things failed. My patch passed the dry run last night and I submitted this morning -- maybe we should have a tighter control of when a dry run pass skips the CQ.
Hm. I think it's just that they both ran bots and passed, but neither would pass if the other had landed. So they conflicted without a merge conflict.
Reverting either one should fix the problem, and then rebase it on top of the other. Thanks for helping chris.
Has this bug been fixed now? It seems the reverts have landed.
Status: Fixed (was: Assigned)

Sign in to add a comment