New issue
Advanced search Search tips

Issue 771192 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

3.5%-8.1% regression in speedometer at 505569:505837 ([ic] Properly handle polymorphic symbol accesses)

Project Member Reported by majidvp@chromium.org, Oct 3 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=771192

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=66e10da67e804ddd48e3748db326e1e91cd5a4ef307145290c695e0102ceb727


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus6
android-nexus7v2
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
linux-release
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author bmeurer@chromium.org ===

Hi bmeurer@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Benedikt Meurer
  Commit : 08db4d7652967c1ed12450a73ff53f5d6bbf1fdf
  Date   : Mon Oct 02 12:35:05 2017
  Subject: [ic] Properly handle polymorphic symbol accesses.

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total
  Change       : 8.54% | 3550.13 -> 3853.21783333

Revision                           Result                  N
chromium@505615                    3550.13 +- 26.8473      6      good
chromium@505680                    3565.38 +- 48.7547      6      good
chromium@505713                    3576.12 +- 29.042       6      good
chromium@505729                    3578.61 +- 56.881       6      good
chromium@505731                    3568.0 +- 52.0341       6      good
chromium@505731,v8@08db4d7652      3840.01 +- 64.0718      6      bad       <--
chromium@505731,v8@17d86d76fb      3814.58 +- 41.8467      6      bad
chromium@505731,v8@1fa0f9ba4c      3854.5 +- 78.0265       6      bad
chromium@505732                    3836.82 +- 29.3711      6      bad
chromium@505733                    3862.22 +- 24.1209      6      bad
chromium@505737                    3851.08 +- 47.6463      6      bad
chromium@505745                    3853.22 +- 91.7761      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966742604631847840


For feedback, file a bug with component Speed>Bisection
 Issue 771319  has been merged into this issue.
Cc: jkummerow@chromium.org
Components: Blink>JavaScript>Runtime
Labels: -Pri-2 Performance Performance-Sheriff-V8 Pri-1
Status: Started (was: Assigned)
Summary: 3.5%-8.1% regression in speedometer at 505569:505837 ([ic] Properly handle polymorphic symbol accesses) (was: 3.5%-8.1% regression in speedometer at 505569:505837)
This should be fixed with https://chromium-review.googlesource.com/695307, let's wait for the next roll and check again.
 Issue 771582  has been merged into this issue.
Status: Fixed (was: Started)
Back to normal, as expected. Closing.

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: mac_10_12_mini_8gb_perf_bisect
  Benchmark    : speedometer
  Metric       : BackboneJS-TodoMVC/BackboneJS-TodoMVC

Revision             Result                  N
chromium@505788      347.959 +- 28.6684      21      good
chromium@505949      347.299 +- 45.6784      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966591928018182352


For feedback, file a bug with component Speed>Bisection

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Benedikt Meurer
  Commit : 08db4d7652967c1ed12450a73ff53f5d6bbf1fdf
  Date   : Mon Oct 02 12:35:05 2017
  Subject: [ic] Properly handle polymorphic symbol accesses.

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/browse_media/browse_media_tumblr
  Change       : 13.64% | 14220803.9465 -> 16160122.9065

Revision                           Result                   N
chromium@505696                    14220804 +- 1098127      6      good
chromium@505721                    13848971 +- 583312       6      good
chromium@505727                    14049117 +- 903924       6      good
chromium@505730                    14184650 +- 851184       6      good
chromium@505731                    14061118 +- 663415       6      good
chromium@505731,v8@08db4d7652      15469911 +- 968192       6      bad       <--
chromium@505731,v8@17d86d76fb      15276381 +- 2011269      9      bad
chromium@505731,v8@1fa0f9ba4c      15392599 +- 959147       6      bad
chromium@505732                    15165057 +- 1310554      6      bad
chromium@505733                    15293947 +- 1150471      6      bad
chromium@505745                    15145933 +- 1286876      9      bad
chromium@505793                    16160123 +- 1366205      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.tumblr v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966591902103069472


For feedback, file a bug with component Speed>Bisection
Cc: jarin@google.com jarin@chromium.org
 Issue 772284  has been merged into this issue.
 Issue 772283  has been merged into this issue.
 Issue 772281  has been merged into this issue.
 Issue 772285  has been merged into this issue.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

Cc: u...@chromium.org
 Issue 774458  has been merged into this issue.
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

 Issue 774464  has been merged into this issue.
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

Cc: vmi...@chromium.org
 Issue 771322  has been merged into this issue.
Project Member

Comment 19 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: tebbi@chromium.org
 Issue 774898  has been merged into this issue.

Sign in to add a comment