Remove "Multiply" from ImageBuffer::GetImageData() and ::PutByteArray() |
||
Issue description
The first parameter passed to ImageBuffer::GetImageData() and ImageBuffer::PutByteArray() is of type Multiply {kMultiplied, kUnmultiplied}. However, all the call sites only use kUnmultiplied as ImageData is always assumed to be in gamma-encoded unpremultiplied. The enum and the param can be removed to simplify the code.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e7396b5b8a31b2eb7136046016c54b643f7b482 commit 6e7396b5b8a31b2eb7136046016c54b643f7b482 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Thu Oct 26 19:20:50 2017 Remove "Multiply" from ImageBuffer The first parameter passed to ImageBuffer::GetImageData() and ImageBuffer::PutByteArray() is of type Multiply {kMultiplied, kUnmultiplied}. However, all the call sites only use kUnmultiplied. This change list removes this enum definition and call sites. Bug: 771182 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b3c2fd3c77c30f336ea56164503126bbcbad4c5 Reviewed-on: https://chromium-review.googlesource.com/739790 Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#511917} [modify] https://crrev.com/6e7396b5b8a31b2eb7136046016c54b643f7b482/third_party/WebKit/Source/core/layout/shapes/Shape.cpp [modify] https://crrev.com/6e7396b5b8a31b2eb7136046016c54b643f7b482/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp [modify] https://crrev.com/6e7396b5b8a31b2eb7136046016c54b643f7b482/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp [modify] https://crrev.com/6e7396b5b8a31b2eb7136046016c54b643f7b482/third_party/WebKit/Source/platform/graphics/ImageBuffer.h [modify] https://crrev.com/6e7396b5b8a31b2eb7136046016c54b643f7b482/third_party/WebKit/Source/platform/graphics/ImageBufferTest.cpp
,
Oct 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by zakerinasab@chromium.org
, Oct 25 2017