Update ndk version |
|||||||||||||
Issue description//third_party/android_tools/ndk is still at r12b. Latest stable is v15. My main motivation for upgrading is to be able to use upstream libc++, and then look at upstreaming CHROMIUM_CXX_TWEAK_INLINES. There's a bug for a continuous integration bot (bug 668202), although I don't think this is a prerequisite for updating.
,
Oct 3 2017
It's not urgent.
,
Oct 24 2017
,
Oct 24 2017
The new NDK would also be useful for AHardwareBuffer support as being implemented for GpuMemoryBuffer for Android - current plan is to use a minimal hardware_buffer.h header with compatible declarations as a stopgap, but this should be replaced with the real header once it's available.
,
Nov 9 2017
,
Nov 9 2017
,
Nov 10 2017
This is relevant to multiple VR issues, so is there anything I can do to help out?
,
Nov 17 2017
I've push r16 stable to a branch called "r16" within //android_tools/ndk. If you'd like to work on build changes so that it can roll, that would be awesome. To test it out, just sync in locally to the branch and try to compile chrome. From what I can tell the biggest difference is the move to unified headers: https://android.googlesource.com/platform/ndk/+/ndk-release-r16/docs/UnifiedHeaders.md
,
Nov 17 2017
,
Nov 28 2017
Working CLs are available at: Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/777822 NDK: https://chromium-review.googlesource.com/c/android_ndk/+/784230 Skia: https://skia-review.googlesource.com/c/skia/+/75422 With those three patches applied, chrome_public_apk, chrome_modern_public_apk, and monochrome_public_apk compile and seem to run fine on arm and arm64.
,
Nov 28 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/592c225b03ca677a1217eabdbc38eede6afcdb14 commit 592c225b03ca677a1217eabdbc38eede6afcdb14 Author: bsheedy <bsheedy@google.com> Date: Tue Nov 28 19:29:57 2017 Make Skia compatible with Android NDK r16 Changes to Skia that are necessary to make Chromium compile with Android NDK r16, which switches to unified headers. Sister CLs: src/third_party/android_tools/ndk: https://chromium-review.googlesource.com/c/android_ndk/+/784230 src/: https://chromium-review.googlesource.com/c/chromium/src/+/777822 Bug: chromium:771171 Change-Id: I3d35df5b99d8eb7d7d938d21b5aecdf4c2d5da0f Reviewed-on: https://skia-review.googlesource.com/75422 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> [modify] https://crrev.com/592c225b03ca677a1217eabdbc38eede6afcdb14/src/core/SkCpu.cpp
,
Nov 30 2017
Ran diagnose_bloat.py for current (r12b)) vs r16 /w patches applied (thanks digit!)
12790 symbols added (+), 30933 changed (~), 12717 removed (-), 797587 unchanged (not shown)
Of changed symbols, 32732 grew, 23699 shrank
Number of unique symbols 516207 -> 516470 (+263)
36 paths added, 74 removed, 4929 changed
Showing 56,440 symbols (aliases not grouped for diffs) with total pss: 43286 bytes
Histogram of symbols based on PSS:
(-32768,-16384]: 1 (-512,-256]: 550 (-8,-4]: 1793 [1,2): 1802 [64,128): 967 [4096,8192): 2
(-16384,-8192]: 2 (-256,-128]: 521 (-4,-2]: 1344 [2,4): 2554 [128,256): 424 [8192,16384): 1
(-8192,-4096]: 3 (-128,-64]: 705 (-2,-1]: 1118 [4,8): 2903 [256,512): 634
(-4096,-2048]: 8 (-64,-32]: 2009 (-1,0): 11918 [8,16): 3176 [512,1024): 44
(-2048,-1024]: 14 (-32,-16]: 1670 {{0}}: 9 [16,32): 3956 [1024,2048): 12
(-1024,-512]: 38 (-16,-8]: 2005 (0,1): 13762 [32,64): 2492 [2048,4096): 3
.text=48.9kb .rodata=-6.82kb .data.rel.ro=76 bytes .data=92 bytes .bss=79 bytes .pak.translations=0 bytes .pak.nontranslated=0 bytes total=42.3kb
Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, p=.pak.translations, P=.pak.nontranslated
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0) -23628 (-48.5%) t@0xb994a0 -23628 (25664->2036) components/viz/service/display/shader.cc
viz::FragmentShader::GetShaderSource const
~ 1) -37704 (-77.4%) t@0xb98880 -14076 (15304->1228) components/viz/service/display/shader.cc
viz::VertexShader::GetShaderString const
~ 2) -49348 (-101.4%) t@0xa668d0 -11644 (13092->1448) components/viz/common/gl_helper_scaling.cc
viz::GLHelperScaling::GetShaderProgram
+ 3) -38912 (-79.9%) t@0x6ae458 10436 (0->10436) third_party/skia/src/sksl/SkSLIRGenerator.cpp
SkSL::fill_caps
~ 4) -46702 (-95.9%) t@0x1838a00 -7790 (10960->3170) gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
gpu::gles2::CopyTextureCHROMIUMResourceManager::DoCopyTextureInternal
+ 5) -41914 (-86.1%) r@0x0 4787 (0->0) {{no path}}
** aggregate padding of diff'ed symbols
- 6) -46534 (-95.6%) t@0x0 -4620 (4616->0) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a/vfprintf.o
printf_core
- 7) -50764 (-104.3%) r@0x0 -4230 (22->0) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/hash.o
string literal
+ 8) -46668 (-95.9%) r@0x2eb9150 4096 (0->4096) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a/s_exp2.o
tbl
+ 9) -42724 (-87.8%) t@0x2630320 3944 (0->3944) third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/libgcc.a/linux-atomic.o
__sync_fetch_and_add_4
- 10) -46232 (-95.0%) t@0x0 -3508 (3504->0) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a/floatscan.o
__floatscan
~ 11) -42748 (-87.8%) t@0x11006b8 3484 (3148->6632) v8/src/heap/concurrent-marking.cc
v8::internal::ConcurrentMarking::Run
- 12) -46080 (-94.7%) t@0x0 -3332 (3328->0) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a/strtod.o
strtod
~ 13) -48664 (-100.0%) t@0x187e070 -2584 (3228->644) gpu/command_buffer/service/gles2_cmd_srgb_converter.cc
gpu::gles2::SRGBConverter::InitializeSRGBConverterProgram
~ 14) -51084 (-104.9%) t@0x186a178 -2420 (4816->2396) gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
gpu::gles2::GLES2DecoderPassthroughImpl::Initialize
~ 15) -53476 (-109.8%) t@0x6ae3ec -2392 (2500->108) third_party/skia/src/sksl/SkSLIRGenerator.cpp
SkSL::IRGenerator::start
~ 16) -55668 (-114.4%) t@0x352f54 -2192 (3764->1572) base/json/json_parser.cc
base::internal::JSONParser::ConsumeStringRaw
~ 17) -57788 (-118.7%) t@0xf70694 -2120 (4660->2540) v8/src/asmjs/asm-scanner.cc
v8::internal::AsmJsScanner::AsmJsScanner
~ 18) -59812 (-122.9%) t@0x854720 -2024 (3392->1368) ui/gfx/color_transform.cc
gfx::ColorTransformSkTransferFn::AppendTransferShaderSource const
~ 19) -61632 (-126.6%) t@0x189f294 -1820 (3320->1500) gpu/command_buffer/service/texture_manager.cc
gpu::gles2::TextureManager::ValidateTextureParameters
~ 20) -59876 (-123.0%) t@0x955a2c 1756 (340->2096) third_party/WebKit/common/mime_util/mime_util.cc
base::LazyInstance::Get
~ 21) -58168 (-119.5%) t@0x1378ac8 1708 (804->2512) v8/src/inspector/v8-injected-script-host.cc
******************************Resource Sizes Diff******************************
StaticInitializersCount
+1 count count
MonochromePublic.apk_Breakdown (+36,988 bytes)
+2 bytes Zip Overhead
+36,988 bytes Native code size
-2 bytes Package metadata size
MonochromePublic.apk_Specifics
+36,988 bytes normalized apk size
+36,988 bytes main lib size
Not really much I can derive from this other than "some symbols were renamed, and things get a bit bigger". I'd guess the initial symbol list is just methods that no longer have so much inlined into them. The histogram tells a more clear story - that some always-inlined methods got a tiny bit larger.
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/4394a76c4460630a42c904724db226f9e24d1ff9 commit 4394a76c4460630a42c904724db226f9e24d1ff9 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Dec 06 02:59:37 2017 Roll ndk to r16 Bug: 771171 Change-Id: I1e4bdf64e918b7f38dcfd34cfd1fb6f0ff48a0a9 Reviewed-on: https://chromium-review.googlesource.com/809761 Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/4394a76c4460630a42c904724db226f9e24d1ff9/DEPS
,
Dec 8 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/apache-portable-runtime/+/c3f11fcd86b42922834cae91103cf068246c6bb6 commit c3f11fcd86b42922834cae91103cf068246c6bb6 Author: bsheedy <bsheedy@chromium.org> Date: Wed Dec 13 20:49:19 2017 Android NDK r16 workaround Removes HAVE_GETGRGID_R and HAVE_GETGRNAM_R defines since they cause issues with newer Android NDK versions. Bug: 771171 Change-Id: I8a613a580879ef0d579573eb04285b474c3b8a6b [modify] https://crrev.com/c3f11fcd86b42922834cae91103cf068246c6bb6/include/arch/unix/apr_private.h
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c52cba07ef394d110e034b6307006d1615cb7da8 commit c52cba07ef394d110e034b6307006d1615cb7da8 Author: bsheedy <bsheedy@chromium.org> Date: Thu Dec 14 00:49:40 2017 Fix implicit conversions in disasm-arm64.cc Adds static_cast<int> to a number of return values in disasm-arm64.cc. The implicit conversion from size_t (unsigned long) to int was causing compilation warnings/errors when upgrading to Android NDK r16. Bug: chromium:771171 Change-Id: I9a5f80d65565e1a9ab4caf2cf874240f04f406a1 Reviewed-on: https://chromium-review.googlesource.com/826254 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50094} [modify] https://crrev.com/c52cba07ef394d110e034b6307006d1615cb7da8/src/arm64/disasm-arm64.cc
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/a8d40d515d9f2fe4491abd80fa009da6763417c8 commit a8d40d515d9f2fe4491abd80fa009da6763417c8 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Dec 18 18:41:35 2017 Roll ndk to pick up revert of TWEAK_INLINES Bug: 771171 Change-Id: I9062f482e766eecd64fd1bdb8a724a2f0659661a Reviewed-on: https://chromium-review.googlesource.com/833106 Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/a8d40d515d9f2fe4491abd80fa009da6763417c8/DEPS
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530 commit 2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530 Author: bsheedy <bsheedy@chromium.org> Date: Tue Dec 19 17:41:26 2017 Update Android NDK to r16 This contains all the src/ changes necessary to make Chromium compile with Android NDK r16. Most changes are to make the code compatible with the unified headers that are used now. The libwebm revision is updated to a newer version in order to get a fix for using unified headers that was added a while back, but never rolled into Chromium. Sister CLs: src/third_party/skia/: https://skia-review.googlesource.com/c/skia/+/75422 src/third_party/android_tools/ndk/: https://chromium-review.googlesource.com/c/android_ndk/+/784230 Bug: 771171 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I643f9f7bd75d111e540778d2fdf8c20851485a5a Reviewed-on: https://chromium-review.googlesource.com/777822 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#525076} [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/DEPS [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/allocator/allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/android/linker/legacy_linker_jni.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/android/linker/modern_linker_jni.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/files/file.h [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/files/file_posix.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/files/file_util_posix.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/os_compat_android.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/base/os_compat_android.h [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/build/config/android/BUILD.gn [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/build/config/android/config.gni [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/build/config/compiler/BUILD.gn [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/build/config/posix/BUILD.gn [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/build/config/sysroot.gni [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/chrome/android/static_initializers.gni [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/device/usb/usb_device_handle_usbfs.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/media/audio/android/opensles_output.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/media/audio/android/opensles_output.h [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/media/audio/android/opensles_wrapper.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/net/socket/udp_socket_posix.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/sandbox/linux/syscall_broker/broker_command.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/sandbox/linux/syscall_broker/broker_file_permission.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/sandbox/linux/syscall_broker/broker_host.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/third_party/android_crazy_linker/src/src/crazy_linker_library_list.cpp [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/third_party/android_crazy_linker/src/src/crazy_linker_thread.cpp [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/third_party/android_crazy_linker/src/src/crazy_linker_util.h [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/tools/android/memconsumer/memconsumer_hook.cc [modify] https://crrev.com/2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530/tools/android/memtrack_helper/memtrack_helper.c
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5ef3eda9fe860beae48d55dac5961baf196dc6f commit c5ef3eda9fe860beae48d55dac5961baf196dc6f Author: Brian Sheedy <bsheedy@chromium.org> Date: Tue Dec 19 19:10:07 2017 Revert "Update Android NDK to r16" This reverts commit 2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530. Reason for revert: Breaks MIPS and x86/x64 builders. Original change's description: > Update Android NDK to r16 > > This contains all the src/ changes necessary to make > Chromium compile with Android NDK r16. Most changes > are to make the code compatible with the unified > headers that are used now. > > The libwebm revision is updated to a newer version in > order to get a fix for using unified headers that was > added a while back, but never rolled into Chromium. > > Sister CLs: > src/third_party/skia/: https://skia-review.googlesource.com/c/skia/+/75422 > src/third_party/android_tools/ndk/: https://chromium-review.googlesource.com/c/android_ndk/+/784230 > > Bug: 771171 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I643f9f7bd75d111e540778d2fdf8c20851485a5a > Reviewed-on: https://chromium-review.googlesource.com/777822 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525076} TBR=dcheng@chromium.org,dalecurtis@chromium.org,rmcilroy@chromium.org,pfeldman@chromium.org,tsepez@chromium.org,simonb@chromium.org,agrieve@chromium.org,scottmg@chromium.org,rsesek@chromium.org,zhongyi@chromium.org,bsheedy@chromium.org,ryansturm@chromium.org Change-Id: Ie24d902f9fa6f7c8add5ba553405dcfe6e8e4f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771171 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/834608 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525096} [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/DEPS [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/allocator/allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/android/linker/legacy_linker_jni.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/android/linker/modern_linker_jni.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/files/file.h [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/files/file_posix.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/files/file_util_posix.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/os_compat_android.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/base/os_compat_android.h [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/build/config/android/BUILD.gn [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/build/config/android/config.gni [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/build/config/compiler/BUILD.gn [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/build/config/posix/BUILD.gn [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/build/config/sysroot.gni [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/chrome/android/static_initializers.gni [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/device/usb/usb_device_handle_usbfs.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/media/audio/android/opensles_output.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/media/audio/android/opensles_output.h [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/media/audio/android/opensles_wrapper.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/net/socket/udp_socket_posix.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/sandbox/linux/syscall_broker/broker_command.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/sandbox/linux/syscall_broker/broker_file_permission.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/sandbox/linux/syscall_broker/broker_host.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/third_party/android_crazy_linker/src/src/crazy_linker_library_list.cpp [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/third_party/android_crazy_linker/src/src/crazy_linker_thread.cpp [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/third_party/android_crazy_linker/src/src/crazy_linker_util.h [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/tools/android/memconsumer/memconsumer_hook.cc [modify] https://crrev.com/c5ef3eda9fe860beae48d55dac5961baf196dc6f/tools/android/memtrack_helper/memtrack_helper.c
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/7d781b3544ef67dfa8c7c0c1a347b818c49c42bc commit 7d781b3544ef67dfa8c7c0c1a347b818c49c42bc Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Dec 20 02:28:00 2017 Roll ndk to include CHROMIUM_LIBCPP_INLINE_VISIBILITY patch Bug: 771171 Change-Id: If6eb273779966e97edc8b0630e6aa3dee73777b5 Reviewed-on: https://chromium-review.googlesource.com/834712 Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/7d781b3544ef67dfa8c7c0c1a347b818c49c42bc/DEPS
,
Dec 22 2017
,
Dec 28 2017
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/breakpad/breakpad/+/4a02ec03038d9d6f870f42d5070591512f488db0 commit 4a02ec03038d9d6f870f42d5070591512f488db0 Author: bsheedy <bsheedy@chromium.org> Date: Wed Jan 03 21:22:16 2018 Add asm and machine headers Adds asm/ and machine/ directories to src/common/android/include. This is necessary because some required files for MIPS were removed in newer Android NDK versions, which broke Breakpad compilation. Bug: 771171 Change-Id: Ie6a079b6b8130b549ebc6d0bc4aef0e47e7bd6c2 Reviewed-on: https://chromium-review.googlesource.com/835282 Reviewed-by: Mark Mentovai <mark@chromium.org> [modify] https://crrev.com/4a02ec03038d9d6f870f42d5070591512f488db0/src/common/android/breakpad_getcontext.S [add] https://crrev.com/4a02ec03038d9d6f870f42d5070591512f488db0/src/common/android/include/asm-mips/regdef.h [add] https://crrev.com/4a02ec03038d9d6f870f42d5070591512f488db0/src/common/android/include/asm-mips/asm.h [add] https://crrev.com/4a02ec03038d9d6f870f42d5070591512f488db0/src/common/android/include/asm-mips/README.md [add] https://crrev.com/4a02ec03038d9d6f870f42d5070591512f488db0/src/common/android/include/asm-mips/fpregdef.h
,
Jan 4 2018
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a59f25dbac3347aa8b4123e8efb682de2a9821c commit 2a59f25dbac3347aa8b4123e8efb682de2a9821c Author: bsheedy <bsheedy@chromium.org> Date: Thu Jan 04 17:48:01 2018 Reland "Update Android NDK to r16" This is a reland of 2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530 Original change's description: > Update Android NDK to r16 > > This contains all the src/ changes necessary to make > Chromium compile with Android NDK r16. Most changes > are to make the code compatible with the unified > headers that are used now. > > The libwebm revision is updated to a newer version in > order to get a fix for using unified headers that was > added a while back, but never rolled into Chromium. > > Sister CLs: > src/third_party/skia/: https://skia-review.googlesource.com/c/skia/+/75422 > src/third_party/android_tools/ndk/: https://chromium-review.googlesource.com/c/android_ndk/+/784230 > > Bug: 771171 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I643f9f7bd75d111e540778d2fdf8c20851485a5a > Reviewed-on: https://chromium-review.googlesource.com/777822 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525076} TBR=rsesek@chromium.org,pfeldman@chromium.org,scottmg@chromium.org,zhongyi@chromium.org,dcheng@chromium.org,dalecurtis@chromium.org Bug: 771171 Change-Id: I5e2288bf3f94359a0afe6c16293bcdecd0f02514 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/834609 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#527029} [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/DEPS [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/allocator/allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/android/linker/legacy_linker_jni.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/files/file.h [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/files/file_posix.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/files/file_util_posix.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/os_compat_android.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/base/os_compat_android.h [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/build/config/android/BUILD.gn [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/build/config/android/config.gni [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/build/config/compiler/BUILD.gn [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/build/config/posix/BUILD.gn [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/build/config/sysroot.gni [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/chrome/android/static_initializers.gni [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/device/usb/usb_device_handle_usbfs.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/media/audio/android/opensles_output.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/media/audio/android/opensles_output.h [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/media/audio/android/opensles_wrapper.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/net/socket/udp_socket_posix.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/sandbox/linux/syscall_broker/broker_command.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/sandbox/linux/syscall_broker/broker_file_permission.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/sandbox/linux/syscall_broker/broker_host.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/third_party/android_crazy_linker/src/src/crazy_linker_library_list.cpp [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/third_party/android_crazy_linker/src/src/crazy_linker_thread.cpp [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/third_party/android_crazy_linker/src/src/crazy_linker_util.h [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/tools/android/memconsumer/memconsumer_hook.cc [modify] https://crrev.com/2a59f25dbac3347aa8b4123e8efb682de2a9821c/tools/android/memtrack_helper/memtrack_helper.c
,
Jan 4 2018
The update has been in for a few hours and seems to have made it through all the chromium.android bots by now without issue, so I think we're all finished. I'll re-open if it gets reverted later down the line for some reason.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/201f47850c945da8659abc2afabaa35252df8b03 commit 201f47850c945da8659abc2afabaa35252df8b03 Author: Daniel Bratell <bratell@opera.com> Date: Mon Jul 23 20:23:46 2018 Delete temporary local AHardwareBuffer definition While waiting for a newer ndk, some constants and types were locally declared. Since January there is an NDK that contains those types so the local declarations are not needed anymore In some jumbo builds the local and ndk declaration clashed so it is time to drop the local declarations, but keeping some types still needed by the dynamic lookup of some (to be public) internal functions. Bug: 771171 Change-Id: Ie29ad63108b6c7aef857752daf6741902fdd749e Reviewed-on: https://chromium-review.googlesource.com/1141735 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#577237} [modify] https://crrev.com/201f47850c945da8659abc2afabaa35252df8b03/base/BUILD.gn [delete] https://crrev.com/ecab7921131a4c2c37ae27dad912126f5bdb196f/base/android/android_hardware_buffer_abi.h [modify] https://crrev.com/201f47850c945da8659abc2afabaa35252df8b03/base/android/android_hardware_buffer_compat.h [modify] https://crrev.com/201f47850c945da8659abc2afabaa35252df8b03/build/config/android/BUILD.gn |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by jbudorick@chromium.org
, Oct 3 2017