New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771166 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: pes_pid == selected_video_pid_ in mp2t_stream_parser.cc

Project Member Reported by ClusterFuzz, Oct 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6378943434457088

Fuzzer: libFuzzer_mediasource_MP2T_AACLC_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pes_pid == selected_video_pid_ in mp2t_stream_parser.cc
  media::mp2t::Mp2tStreamParser::OnVideoConfigChanged
  void base::internal::FunctorTraits<void
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=505390:505425

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6378943434457088

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Labels: M-63 Test-Predator-Correct
Owner: dougsteed@chromium.org
Status: Assigned (was: Untriaged)
Test Predator has given the following results:

Declare intent to use sample-aes later in the stream. by dougsteed@chromium.org
Changelist touched lines near the crashed line in frame #5 media::mp2t::Mp2tStreamParser::OnVideoConfigChanged(int, media::VideoDecoderConfig const&) (distance = 62 lines away)
Top touched frame is #5 media::mp2t::Mp2tStreamParser::OnVideoConfigChanged(in mp2t_stream_parser.cc)
Changed files descriptors.cc, descriptors.h, es_parser_adts.cc, es_parser_h264.cc, mp2t_stream_parser.cc, mp2t_stream_parser.h, mp2t_stream_parser_unittest.cc, ts_section_cat.cc, ts_section_cat.h, with the same CrashedDirectory(media/formats/mp2t) as mp2t_stream_parser.cc (in frame#5), es_adapter_video.cc (in frame#11)
Touched files in stacktrace - mp2t_stream_parser.cc
Changed files descriptors.cc, descriptors.h, es_parser_adts.cc, es_parser_h264.cc, mp2t_stream_parser.cc, mp2t_stream_parser.h, mp2t_stream_parser_unittest.cc, ts_section_cat.cc, ts_section_cat.h, README, bear-1280x720-hls-with-CAT.bin, with the same CrashedComponent(Internals>Media) as mp2t_stream_parser.cc (in frame#5), es_adapter_video.cc (in frame#11)

@dougsteed  -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Thank You.
Project Member

Comment 2 by ClusterFuzz, Oct 3 2017

Components: Internals>Core Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: dougsteed@chromium.org
Owner: servolk@chromium.org
Don't know if Doug works on this anymore.
Cc: servolk@chromium.org
Owner: dougsteed@chromium.org
We just chatted about this earlier today, I believe Doug has a fix CL, but I can't find it right now. Doug, did you upload your CL to Gerrit or did you manage to somehow upload it to rietveld? In any case I can't find it right now. Could you add Dale to it as well?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ca6be96591b2d6b717ee97aa69efa9fbd9d76e

commit d1ca6be96591b2d6b717ee97aa69efa9fbd9d76e
Author: Doug Steedman <dougsteed@chromium.org>
Date: Wed Oct 04 21:27:12 2017

Fix H.264 in MPEG2 TS.

I only verified one setting of a compile time boolean,
breaking the code when it had the other setting.

R=servolk@chromium.org, xhwang@chromium.org

Bug:  771166 
Change-Id: Id22d6dcfaed6e2ffb247000afd2b968756c05b0f
Reviewed-on: https://chromium-review.googlesource.com/699056
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Doug Steedman <dougsteed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506523}
[modify] https://crrev.com/d1ca6be96591b2d6b717ee97aa69efa9fbd9d76e/media/formats/mp2t/mp2t_stream_parser.cc

Project Member

Comment 7 by ClusterFuzz, Oct 5 2017

ClusterFuzz has detected this issue as fixed in range 506501:506528.

Detailed report: https://clusterfuzz.com/testcase?key=6378943434457088

Fuzzer: libFuzzer_mediasource_MP2T_AACLC_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pes_pid == selected_video_pid_ in mp2t_stream_parser.cc
  media::mp2t::Mp2tStreamParser::OnVideoConfigChanged
  void base::internal::FunctorTraits<void
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=505390:505425
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=506501:506528

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6378943434457088

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 5 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6378943434457088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment