New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clarify "Media.FallbackToHighLatencyAudioPath" UMA and fallback to fake audio streams

Project Member Reported by olka@chromium.org, Oct 3 2017

Issue description

We need to understand what percentage of audio ends up with a fake stream.
 

Comment 1 by olka@chromium.org, Oct 3 2017

Labels: -Pri-3 M-63 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b802271269655b1937d05ceae3cbd6aa7f01f4b

commit 6b802271269655b1937d05ceae3cbd6aa7f01f4b
Author: Olga Sharonova <olka@chromium.org>
Date: Fri Oct 06 20:16:27 2017

AudioOutputDispatcher and Resampler cleanup

Code cleanup and fixes of some inconsistencies. UMA metrics for fallback to fake streams to be
added in a follow-up CL

Bug: 764071, 771157 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iab82c5d6f038a06995eaf5fa1ce0119318062e84
Reviewed-on: https://chromium-review.googlesource.com/702241
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507161}
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_dispatcher.cc
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_dispatcher.h
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_dispatcher_impl.cc
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_dispatcher_impl.h
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_proxy_unittest.cc
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/6b802271269655b1937d05ceae3cbd6aa7f01f4b/media/audio/audio_output_resampler.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/101ded10cf4bec4c1f891a086ddb977d225b295b

commit 101ded10cf4bec4c1f891a086ddb977d225b295b
Author: Olga Sharonova <olka@chromium.org>
Date: Wed Oct 11 20:02:26 2017

Detailed UMA stats for AudioOutputResample::OpenStream results

We need a better understanding of when fallback to fake audio stream
happens.

Bug:  771157 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib158693210e5c9856723945533b1fbb0a8e4bc97
Reviewed-on: https://chromium-review.googlesource.com/706214
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508083}
[modify] https://crrev.com/101ded10cf4bec4c1f891a086ddb977d225b295b/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/101ded10cf4bec4c1f891a086ddb977d225b295b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/101ded10cf4bec4c1f891a086ddb977d225b295b/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e830a0e34fe94ea30221c1441294608c1ee95c

commit 68e830a0e34fe94ea30221c1441294608c1ee95c
Author: Olga Sharonova <olka@chromium.org>
Date: Thu Oct 12 09:38:08 2017

UMA for stream format used for AudioOutputStreamProxy creation

Bug:  771157 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I02047d77bdc3a3918493dafe6158e594a9581e08
Reviewed-on: https://chromium-review.googlesource.com/702282
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508289}
[modify] https://crrev.com/68e830a0e34fe94ea30221c1441294608c1ee95c/media/audio/audio_manager_base.cc
[modify] https://crrev.com/68e830a0e34fe94ea30221c1441294608c1ee95c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/68e830a0e34fe94ea30221c1441294608c1ee95c/tools/metrics/histograms/histograms.xml

Comment 5 by olka@chromium.org, Nov 28 2017

Status: Fixed (was: Started)

Sign in to add a comment