Most visited tiles appears to be misaligned on closing GLIF animation |
|||||
Issue descriptionApp Version: 63.0.3231.0 Canary iOS Version: 9.3.5, 10.3.3 and 11.0 Device: iPhone only Pre-condition: Enable the content suggestions from chrome experimental settings Steps to reproduce: 1. Launch chrome in landscape and navigate to NTP 2. Change the device orientation to landscape 3. Tap on the mic in the omnibox 4. Once the GLIF animation is displayed change the device orientation to portrait 5. Close the GLIF animation Observed results: Notice the tiles of NTP appears as misaligned for a very few seconds Expected results: Tiles of NTP shouldn’t be misaligned Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M61(happening only when content suggestion exists in NTP) Bug reproducible on the current beta channel build (App Version, iOS Version): yes on M62 beta Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8ZW01cE9VdWZfZkk/view?usp=sharing
,
Oct 9 2017
,
Oct 16 2017
This is because the resizing of the insets of the collection is happening when the collection is not presented. When voice search is closing, the new constraints will only be used once the animation is over. kkhorimoto@: is it possible to have a notification in the NTP when the voice search panel is getting dismissed?
,
Oct 16 2017
Would kVoiceSearchWillHideNotification from voice_search_notification_names.h work?
,
Oct 18 2017
Actually this happens if anything is presented in front of the NTP during the rotation (voice search, settings...). Removing the Voice Search tag.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57f53584606e5fc26c3fcb8698f2e0d577b2d20b commit 57f53584606e5fc26c3fcb8698f2e0d577b2d20b Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 19 13:09:51 2017 Invalidate layout when NTP will appear When the NTP will appear, the layout needs to be invalidated. It ensures that the insets for the Most Visited section are correct when the device is rotated while another screen (e.g. settings) is presented in front of the NTP. Bug: 771149 Change-Id: If8c926fbb0e5cca860b31c4ccc7b672fe49b9e80 Reviewed-on: https://chromium-review.googlesource.com/726082 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#510069} [modify] https://crrev.com/57f53584606e5fc26c3fcb8698f2e0d577b2d20b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Oct 19 2017
,
Oct 24 2017
Verified on: App Version: 64.0.3248.0 canary Devices: iPhone 7, iPhone 8 Plus iOS Versions: 10.3.3, 11.1 Most visited tiles are aligned properly on closing GLIF animation. Tested with portrait and landscape device orientations, issue is fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sczs@chromium.org
, Oct 4 2017Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)