New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771140 link

Starred by 1 user
Status: Duplicate
Merged: issue 774773
Owner:
beccahughes@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Size of volume slider in video controller is improper after zooming in.

Reported by vku...@etouch.net, Oct 3 2017 
Chrome Version: 63.0.3230.0 (Official Build)Revision da95e4026511e4539097b7dc8e09c21cb92a0aee-refs/heads/master@{#505511} (32/64-bit)
OS:Windows (7,8,8.1,10),Mac OS X(10.12.6).

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://www.quirksmode.org/html5/tests/video.html
(2)After loading the page click on fullscreen icon of video.
(3)Press ctrl++ to 200% zoom in the video and observe the volume slider.

Actual: Size of volume slider in video controller is improper after zooming in.

Expected: Size of volume slider in video controller should be properly displayed after zoomin in

This is a regression issue broken in 'M63' and below is the manual regression range:
Good Build: 63.0.3226.0 
Bad Build:  63.0.3227.0
Actual_video.mp4
806 KB View Download
Expected_video.mp4
480 KB View Download

Comment 1 by vku...@etouch.net, Oct 3 2017

Labels: hasbisect-per-revision OS-Linux
Owner: beccahughes@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 504965 (known good), but no later than 504966 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/41ed4a4682284e379929281189ede6a9e13a1fb4..46fb5c855a8622fe73a5c8000b7370407b9122af

Suspect : https://chromium.googlesource.com/chromium/src/+/46fb5c855a8622fe73a5c8000b7370407b9122af

@beccahughes: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by ranjitkan@chromium.org, Oct 3 2017

Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 3 by jmukthavaram@chromium.org, Oct 9 2017 

beccahughes@,

Friendly ping to get an update on this issue as it is marked as stable blocker.

Thanks..!

Comment 4 by beccahughes@chromium.org, Oct 9 2017

Status: Started (was: Assigned)
I have a CL out to fix this: https://chromium-review.googlesource.com/c/chromium/src/+/707062
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f707b5e77a29503574c97c35188bf8c9350d7934

commit f707b5e77a29503574c97c35188bf8c9350d7934
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Oct 11 15:59:42 2017

Media Controls: Fix timeline zoom factor

This fixes cases where the user zooms in or out and the timeline
is not scaled correctly. Also hides overflowing content from the
timeline in case something does go wrong.

BUG= 771140 ,771880

Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
Reviewed-on: https://chromium-review.googlesource.com/707062
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507992}
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/linux/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/linux/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac-mac10.9/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win7/media/controls/controls-page-zoom-in-expected.png
[add] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/LayoutTests/platform/win7/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[modify] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/f707b5e77a29503574c97c35188bf8c9350d7934/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 6 by beccahughes@chromium.org, Oct 11 2017

Status: Fixed (was: Started)
This should now be fixed.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71bf235a0db920fd964bd82e06c8526ad1711942

commit 71bf235a0db920fd964bd82e06c8526ad1711942
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Oct 11 18:16:47 2017

Revert "Media Controls: Fix timeline zoom factor"

This reverts commit f707b5e77a29503574c97c35188bf8c9350d7934.

Reason for revert: controls-page-zoom-in.html and controls-page-zoom-out.html tests are failing.
e.g.
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/19126
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/24377
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/26513

Original change's description:
> Media Controls: Fix timeline zoom factor
> 
> This fixes cases where the user zooms in or out and the timeline
> is not scaled correctly. Also hides overflowing content from the
> timeline in case something does go wrong.
> 
> BUG= 771140 ,771880
> 
> Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
> Reviewed-on: https://chromium-review.googlesource.com/707062
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507992}

TBR=mlamouri@chromium.org,jochen@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: Idd44a63dcd1d9a7528785ee7a0b1f2feef8dd4ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  771140 , 771880
Reviewed-on: https://chromium-review.googlesource.com/713557
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508039}
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/linux/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/linux/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac-mac10.9/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win7/media/controls/controls-page-zoom-in-expected.png
[delete] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/third_party/WebKit/LayoutTests/platform/win7/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.png
[modify] https://crrev.com/71bf235a0db920fd964bd82e06c8526ad1711942/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/71bf235a0db920fd964bd82e06c8526ad1711942/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/71bf235a0db920fd964bd82e06c8526ad1711942/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279fd7acf9b1c1463d1b88618c0a20d29d0e653d

commit 279fd7acf9b1c1463d1b88618c0a20d29d0e653d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Oct 16 11:42:55 2017

Reland "Media Controls: Fix timeline zoom factor"

This is a reland of f707b5e77a29503574c97c35188bf8c9350d7934

The change was reverted because controls-page-zoom* was flaking.
This changes those tests from Pixel+Layout tests to layout only.

Original change's description:
> Media Controls: Fix timeline zoom factor
> 
> This fixes cases where the user zooms in or out and the timeline
> is not scaled correctly. Also hides overflowing content from the
> timeline in case something does go wrong.
> 
> BUG= 771140 ,771880
> 
> Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
> Reviewed-on: https://chromium-review.googlesource.com/707062
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507992}

Bug:  771140 , 771880,  774773 
Change-Id: Ifd6cee02081acc2d77c3916544844689b684272e
Reviewed-on: https://chromium-review.googlesource.com/715257
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509022}
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/content/shell/test_runner/test_runner.cc
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 9 by beccahughes@chromium.org, Oct 16 2017

Status: Started (was: Fixed)
This should be fixed now. @jmukthavaram - please can you confirm?
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f54cb9676beffb6bb04ac11ef6b7874d84fc050

commit 7f54cb9676beffb6bb04ac11ef6b7874d84fc050
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Oct 18 08:40:37 2017

Reland "Media Controls: Fix timeline zoom factor"

This is a reland of f707b5e77a29503574c97c35188bf8c9350d7934

The change was reverted because controls-page-zoom* was flaking.
This changes those tests from Pixel+Layout tests to layout only.

Original change's description:
> Media Controls: Fix timeline zoom factor
> 
> This fixes cases where the user zooms in or out and the timeline
> is not scaled correctly. Also hides overflowing content from the
> timeline in case something does go wrong.
> 
> BUG= 771140 ,771880
> 
> Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
> Reviewed-on: https://chromium-review.googlesource.com/707062
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507992}

Bug:  771140 , 771880,  774773 
Change-Id: Ifd6cee02081acc2d77c3916544844689b684272e
Reviewed-on: https://chromium-review.googlesource.com/715257
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509022}(cherry picked from commit 279fd7acf9b1c1463d1b88618c0a20d29d0e653d)
Reviewed-on: https://chromium-review.googlesource.com/725459
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#49}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/content/shell/test_runner/test_runner.cc
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 11 by beccahughes@chromium.org, Oct 20 2017

Mergedinto: 774773
Status: Duplicate (was: Started)
►

Sign in to add a comment