New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771126 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 714618



Sign in to add a comment

Password shown in settings doesn't update with search

Project Member Reported by tmccoy@google.com, Oct 3 2017

Issue description

Chrome Version       : 63.0.3223.8
OS Version: OS X 10.12.6
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Save passwords for abc.com and xyz.com
2. Go to settings -> manage passwords, search for abc.com in "Search Passwords" field 
3. Click show password, enter device password to reveal password for abc.com
4. Search for password for xyz.com

What is the expected result?

Should show the correct username and password for xyz.com

What happens instead of that?

Page shows the correct username, but the password shown is from the last search, abc.com. It doesn't update to show the password for xyz.com


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3223.8 Safari/537.36



 
Labels: Needs-Triage-M63
Components: UI>Browser>Passwords
Labels: Needs-Bisect Triaged-ET
Owner: divya.pa...@techmahindra.com
Able to reproduce the issue on reported version 63.0.3223.8 on Mac 10.12.6, working on the bisect
Status: Untriaged (was: Unconfirmed)
Cc: divya.pa...@techmahindra.com
Labels: -Needs-Bisect OS-Linux OS-Windows
Owner: ----
Able to reproduce the issue on reported version 63.0.3223.8, Latest Canary 63.0.3233.0 using Mac 10.12.6, Ubuntu 14.04 and Windows 10. 

This is a Non-Regression Issue as it is seen from M-62(62.0.3175.0) from the introduction of show password option on chrome://settings/passwords page, hence marking it as Untriaged.
Owner: jdoerrie@chromium.org
Status: Assigned (was: Untriaged)
 Issue 779061  has been merged into this issue.
 Issue 779011  has been merged into this issue.
Cc: jdoerrie@chromium.org kebalaji@chromium.org kkaluri@chromium.org
 Issue 782032  has been merged into this issue.
Status: Started (was: Assigned)
Blocking: 714618
 Issue 788451  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/447990991a286e8085d04c41ef6c016dbdf25e0f

commit 447990991a286e8085d04c41ef6c016dbdf25e0f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Nov 29 19:37:02 2017

Fix Behavior of Visible Passwords

Prior to this change visible passwords were bound to a specific row in
the list of passwords. This led to bugs when the list changed, e.g. when
adding or deleting a password, or changing the list of passwords with a
search filter.

This change fixes this by grouping the password and the UiEntry into a
newly introduced typedef.

Bug:  786312 ,  771126 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I25751d6a20b315290f2c52cc76946f85c413405f
Reviewed-on: https://chromium-review.googlesource.com/779179
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520200}
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/show_password_behavior.js
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/third_party/closure_compiler/externs/passwords_private.js

 Issue 788682  has been merged into this issue.
Status: Fixed (was: Started)
 Issue 792425  has been merged into this issue.
Cc: vamshi.k...@techmahindra.com
 Issue 796993  has been merged into this issue.
 Issue 803101  has been merged into this issue.
 Issue 804283  has been merged into this issue.
 Issue 806716  has been merged into this issue.
The fix landed in 64.0.3281.0

Sign in to add a comment