SnapshotBrowserTest.{Sync,Async}MultiWindowTest fails flakily on Mac10.9 Tests (dbg) and Win7 Tests (dbg) |
||||||||||||||||||||
Issue descriptionSnapshotBrowserTest.AsyncMultiWindowTest and SnapshotBrowserTest.SyncMultiWindowTest is crashing flakily on Mac10.9 Tests (dbg). The first observation is: https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.9%20Tests%20%28dbg%29/45653 but I cannot find any culprit in that build. More failures: https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.9%20Tests%20%28dbg%29/45674 https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.9%20Tests%20%28dbg%29/45661 SnapshotBrowserTest.SyncMultiWindowTest only fails on https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.9%20Tests%20%28dbg%29/45655 but the crash error is the same, so I'm going to disable that too. Crash log snippet: [79872:771:1002/205303.581942:40019762503875:INFO:CONSOLE(1)] "Uncaught ReferenceError: fillWithColor is not defined", source: http://127.0.0.1:53901/test (1) BrowserTestBase received signal: Terminated: 15. Backtrace: 0 libbase.dylib 0x0000000116f9b38e base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x0000000116f9b44d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x0000000116f996fc base::debug::StackTrace::StackTrace() + 28 3 content_browsertests 0x000000010f5c175c content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 540 4 libsystem_platform.dylib 0x00007fff8a32f5aa _sigtramp + 26 5 ??? 0x0000000000000000 0x0 + 0 6 CoreFoundation 0x00007fff8dc2cf15 __CFRunLoopServiceMachPort + 181 7 CoreFoundation 0x00007fff8dc2c539 __CFRunLoopRun + 1161 8 CoreFoundation 0x00007fff8dc2be75 CFRunLoopRunSpecific + 309 9 HIToolbox 0x00007fff85bfaa0d RunCurrentEventLoopInMode + 226 10 HIToolbox 0x00007fff85bfa7b7 ReceiveNextEventCommon + 479 11 HIToolbox 0x00007fff85bfa5bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 12 AppKit 0x00007fff8603624e _DPSNextEvent + 1434 13 AppKit 0x00007fff8603589b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 14 AppKit 0x00007fff8602999c -[NSApplication run] + 553 15 libbase.dylib 0x00000001170982d8 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 312 16 libbase.dylib 0x0000000117095074 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 116 17 libbase.dylib 0x00000001170842bb base::MessageLoop::Run() + 299 18 libbase.dylib 0x0000000117181eb6 base::RunLoop::Run() + 262 19 content_browsertests 0x000000010f6997b4 content::RunThisRunLoop(base::RunLoop*) + 52 20 content_browsertests 0x000000010f69b41b content::MessageLoopRunner::Run() + 251 21 content_browsertests 0x000000010f5d0319 content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) + 361 22 content_browsertests 0x000000010f5cb311 content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) + 561
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73d124de2649b11711e556352df710fcb85f379f commit 73d124de2649b11711e556352df710fcb85f379f Author: Samuel Huang <huangs@chromium.org> Date: Tue Oct 03 18:46:26 2017 Disable SnapshotBorwserTest.{Async,Sync}MultiWindowTest. These tests are flaky on Mac10.9 Tests (dbg) and Win7 Tests (dbg). Disabling on all platforms. BUG= 771119 TBR=kbr@chromium.org Change-Id: I233128d186e8ac26656aa3669cb9f15688db0fdb Reviewed-on: https://chromium-review.googlesource.com/698484 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506122} [modify] https://crrev.com/73d124de2649b11711e556352df710fcb85f379f/content/browser/snapshot_browsertest.cc
,
Oct 3 2017
Re-enabling on Release bots in https://chromium-review.googlesource.com/698884 .
,
Oct 3 2017
Note: failure mode on Win7 Tests (dbg) (1) was a timeout: https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/ https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/63632 [ RUN ] SnapshotBrowserTest.SyncMultiWindowTest DevTools listening on ws://127.0.0.1:51555/devtools/browser/424fed73-ac8f-4bd6-8634-38b2b1518232 [1124:3012:1003/095211.519:21230550:ERROR:direct_composition_surface_win.cc(1094)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE. [1124:3012:1003/095211.582:21230612:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported. [694/1025] SnapshotBrowserTest.SyncMultiWindowTest (TIMED OUT)
,
Oct 3 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91495e7e47253f0a30c1aa5f85f6d452cf6c5af3 commit 91495e7e47253f0a30c1aa5f85f6d452cf6c5af3 Author: Kenneth Russell <kbr@chromium.org> Date: Tue Oct 03 20:53:41 2017 Re-enable disabled SnapshotBrowserTests on Release bots. BUG= 771119 TBR=kjellander@chromium.org, huangs@chromium.org, jam@chromium.org Change-Id: I91b75ed96e1d62a1dbc7d0220b5c2109ed5e1163 Reviewed-on: https://chromium-review.googlesource.com/698884 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506166} [modify] https://crrev.com/91495e7e47253f0a30c1aa5f85f6d452cf6c5af3/content/browser/snapshot_browsertest.cc
,
Oct 3 2017
,
Oct 7 2017
,
Oct 7 2017
,
Oct 12 2017
This apparently flakes in more bots now. Issue 774050 has more details and logs.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cba1253ea52ac983ec926c908aca3b856eb0d7a commit 2cba1253ea52ac983ec926c908aca3b856eb0d7a Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Oct 12 13:10:40 2017 Redisable flaky SnapshotBrowserTest.SyncMultiWindowTest for Mac This test used to cause failures and recently apparently got better but now it's failing again. Redisabling it for Mac and reopening the bugs. TBR=kbr@chromium.org Bug: 774050 , 771119 Change-Id: I3d581fa76f44d8fc1bdc0359892547c43f9d7221 Reviewed-on: https://chromium-review.googlesource.com/715898 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#508327} [modify] https://crrev.com/2cba1253ea52ac983ec926c908aca3b856eb0d7a/content/browser/snapshot_browsertest.cc
,
Oct 13 2017
,
Oct 13 2017
,
Oct 13 2017
,
Oct 13 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/064a1f3a5974481ae060d829beeb82661f922e80 commit 064a1f3a5974481ae060d829beeb82661f922e80 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Oct 13 18:10:53 2017 Re-enable SnapshotBrowserTest.SyncMultiWindowTest. The fix that just landed in Issue 772379 should make this test reliable everywhere. BUG= 771119 , 772379 TBR=fhorschig@chromium.org Change-Id: I6a6a17f98e4b4c33d3bafa81253fc0cf46591657 Reviewed-on: https://chromium-review.googlesource.com/717698 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#508755} [modify] https://crrev.com/064a1f3a5974481ae060d829beeb82661f922e80/content/browser/snapshot_browsertest.cc
,
Oct 13 2017
With the changes here and the fixes from Issue 772379 , this test should be fully reliable. It's still disabled in Debug builds but should work well on, for example, the slower ASAN bots. Please reopen if you find it still flaky.
,
Oct 18 2017
This test SnapshotBrowserTest.SyncMultiWindowTest, along with SnapshotBrowserTest.AsyncMultiWindowTest are flaky on the Win 7 bot. Example failures: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64028 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64037
,
Oct 20 2017
Disabling the multi-window tests on Win Debug in https://chromium-review.googlesource.com/731365 .
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c2dc2af94428eae2df714d9a2576916b7a7b813 commit 1c2dc2af94428eae2df714d9a2576916b7a7b813 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Oct 20 22:37:18 2017 Disable multi-window SnapshotBrowserTests on Win Debug. They're timing out without reporting any errors. Let's see if they're reliable on the other Debug bots. BUG= 771119 TBR=jonross@chromium.org, sky@chromium.org Change-Id: I8c5c53bd6c1d94ff936f51b92ed89331a53d9846 Reviewed-on: https://chromium-review.googlesource.com/731365 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510589} [modify] https://crrev.com/1c2dc2af94428eae2df714d9a2576916b7a7b813/content/browser/snapshot_browsertest.cc
,
Oct 20 2017
Let me close this again as Fixed. Please reopen or file a new bug if you see more flakiness with these new tests. Thanks.
,
Nov 2 2017
Reopneing, we're timing out on the Linux TSan Tests builder. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.memory%3ALinux%20TSan%20Tests https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/13682 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/13567
,
Nov 2 2017
Looking at the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=content_browsertests&tests=SnapshotBrowserTest.SyncMultiWindowTest https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=content_browsertests&tests=SnapshotBrowserTest.AsyncMultiWindowTest the SyncMultiWindowTest and AsyncMultiWindowTest are timing out on these configurations: Linux Chromium OS ASAN LSAN Tests (1) Linux TSAN Tests Will disable the tests just in these scenarios.
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e11aae0c30d30be8f5fffc0d52d40acbbb19a7ee commit e11aae0c30d30be8f5fffc0d52d40acbbb19a7ee Author: Kenneth Russell <kbr@chromium.org> Date: Thu Nov 02 23:08:43 2017 Disable multi-window tests on a couple of sanitizer configurations. They seem to be too slow in these modes. BUG= 771119 TBR=skym@chromium.org Change-Id: Ifd728033147204c48dd395ee48e4b5d418715984 Reviewed-on: https://chromium-review.googlesource.com/752047 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513620} [modify] https://crrev.com/e11aae0c30d30be8f5fffc0d52d40acbbb19a7ee/content/browser/snapshot_browsertest.cc
,
Nov 2 2017
Should no longer run on these configurations. Please reopen if you see more flakes. Thanks.
,
May 29 2018
kbr@: This test becomes flaky on Mac in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1066304 …which does some synchronization between the browser and GPU processes. I'm planning to just disable it on Mac because it was disabled on so many other OSs, but figured I'd give you a heads up in case the trigger is useful.
,
May 30 2018
sdy@: please note that the test was only disabled in a few specific situations, and has otherwise been reliable across a range of configurations. It's not a good idea to blanket disable this test on macOS and I've commented as much on https://chromium-review.googlesource.com/c/chromium/src/+/1066304 . Let's work together to make that CL not introduce flakiness in this test, as it stresses code paths used by other tests. Re-closing as Fixed for the moment. |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 3 2017