New issue
Advanced search Search tips

Issue 771103 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.PopupTest#testPopupWindowsAppearWhenAllowed is flaky on Android Tests

Project Member Reported by kjellander@chromium.org, Oct 3 2017

Issue description

org.chromium.chrome.browser.PopupTest#testPopupWindowsAppearWhenAllowed is flaky on Android Tests. The first observation I can see is
https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/46506

More example failures:
https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/46519
https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/46530

The error seems to trigger due to a timeout:
junit.framework.AssertionFailedError: Criteria not met in allotted time.
	at junit.framework.Assert.fail(Assert.java:50)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117)
	at org.chromium.chrome.browser.PopupTest.testPopupWindowsAppearWhenAllowed(PopupTest.java:118)

I'm going to disable the test.
 
Cc: csharrison@chromium.org
Similar bug in the past:  bug 733365 .
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fd0d82f26fe13a082454c1b46f7bed8010b2b1

commit b4fd0d82f26fe13a082454c1b46f7bed8010b2b1
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Tue Oct 03 10:15:53 2017

Disable flaky org.chromium.chrome.browser.PopupTest#testPopupWindowsAppearWhenAllowed

BUG= 771103 
TBR=tedchoc@chromium.org

Change-Id: I9321fec54c0663ea137313e3eee4b2aecfc5bb2a
Reviewed-on: https://chromium-review.googlesource.com/697424
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505999}
[modify] https://crrev.com/b4fd0d82f26fe13a082454c1b46f7bed8010b2b1/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01dddec5a9f83b12f50fb735ee6db65d96e56712

commit 01dddec5a9f83b12f50fb735ee6db65d96e56712
Author: Ted Choc <tedchoc@google.com>
Date: Wed Jun 06 16:51:41 2018

De-flake PopupTest#testPopupWindowsAppearWhenAllowed

In my local testing, the translate infobar was showing up
on the webpage because it uses latin placeholder text.

This reworks the infobar check to not check for an exact
count, but to look for infobars of a particular type.

BUG= 771103 

Change-Id: Ia6544c386e9e8288f7980a2c14e0b0fba0b14e98
Reviewed-on: https://chromium-review.googlesource.com/1087684
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564925}
[modify] https://crrev.com/01dddec5a9f83b12f50fb735ee6db65d96e56712/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a05c665e65e6602452e2b12cc0a8f828bf95a2

commit a2a05c665e65e6602452e2b12cc0a8f828bf95a2
Author: Ted Choc <tedchoc@google.com>
Date: Fri Jun 15 17:16:29 2018

Further deflake PopupTest#testPopupWindowsAppearWhenAllowed

This removes the other check that ensures a specific number of
infobars isn't showing.  This could be breaking if the translate
infobar showed up.

Stack:
java.lang.AssertionError: Criteria not met in allotted time.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
	at org.chromium.chrome.browser.PopupTest.testPopupWindowsAppearWhenAllowed(PopupTest.java:178)

BUG= 771103 

Change-Id: If439b42e6d0f63fa61cd75ea48bddb2e42571994
Reviewed-on: https://chromium-review.googlesource.com/1101830
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567702}
[modify] https://crrev.com/a2a05c665e65e6602452e2b12cc0a8f828bf95a2/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java

Status: Fixed (was: Assigned)
After that last CL, there were no flakes over the weekend, so I'm going to call this done.

I looked at the last flake before it landed and it was showing the simplified view infobar, so it looks like my assumption was probably correct in the fix.

Sign in to add a comment