New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771102 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Chopped focus is seen on 'Wi-Fi is turned off' text of Network section in Ubertray

Project Member Reported by rkalavakuntla@chromium.org, Oct 3 2017

Issue description

Chrome Version:61.0.3163.113/9765.76.0 Stable-channel Daisy,Reks,Kip
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user -> In Ubertray ->Turn-Off the Wi-Fi ->Press Tab and Observe(please refer video)

Actual:Chopped focus is seen on 'Wi-Fi is turned off' text
Expected:Either there shouldn't be focus as expected or focus should be seen properly.

This is a Regression as same is working fine in 61.0.3147.0/9708.0.0 dev channel Kip

Note:Issue is not seen on Linux,Windows OS

@tbuckley: Please confirm the issue


 
Actual.mp4
7.7 MB View Download
actualchop.jpg
4.3 MB View Download
Expected.mp4
8.2 MB View Download
Labels: ReleaseBlock-Stable
Cc: tbuck...@chromium.org
Labels: -M-61
Owner: zork@chromium.org
We're past the cut for M61. We'll target this to M63.

@zork -- can someone on your team look at this?

Comment 3 by gkihumba@google.com, Oct 27 2017

Any updates?
Owner: sammiequon@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38c9a754438b6111c91d87a910c288f472a49d4

commit f38c9a754438b6111c91d87a910c288f472a49d4
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Nov 02 18:35:37 2017

tray: Fix focus rectangle for tray_info_label.

See  bug 771102  for screenshots. The label covers some of the of the focus
rectangle. Changed to use box layout so the label does not take up more
space than it needs.

Fix two other small bugs.
1) Strings for updating flash cutoff in German. Add label multiline
for that label.
2) Tab focus going on power, even though it is not a button. Users using
tab require to tabs to go from the last highlighted region (time) to the
next (sign out).

Test: manual
Bug:  771102 ,  742283 ,  769240 
Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456
Reviewed-on: https://chromium-review.googlesource.com/750066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513560}
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/power/power_status_view.cc
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/update/tray_update.cc

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Status: Assigned (was: Fixed)
Can you merge the changes to M63- M64 builds? I can still see that the tab focus doesn't shift immediately to sign out from the last highlighted region (i.e. time). It requires 2 tabs to go to Sign out button (as in M64) and 3tabs to go from time region to Sign out button as in M63. 

As on M64 dev build (10124.0.0, 64.0.3265.0), from the issue description in #1: focus is seen on 'Wi-Fi is turned off' text and is highlighted in box layout. Is this expected?
Cc: mkarkada@chromium.org
Labels: Merge-Request-63
I assume part one is meant for  crbug.com/769240 .

Sorry, i'm not quite following the second question.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 13 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
As per the bug description, if I turn off wifi-> Press tab key and navigate through the uber tray, I can see tab focus on 'Wi-Fi is turned off' text. Is this the expected behavior or shouldn't there be any focus on the text?
It says either no focus or proper focus. I think there should be focus, but feel free to start a new bug for discussion.
I see proper focus on the label without any choppings. If this is the expected one, then I can sign off this bug. Thank you!
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Status: Verified (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 13 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9b2b4eade6c978204662cf6c0e08b5129fabb8

commit ac9b2b4eade6c978204662cf6c0e08b5129fabb8
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Nov 13 22:13:18 2017

[merge to m63] tray: Fix focus rectangle for tray_info_label.

See  bug 771102  for screenshots. The label covers some of the of the focus
rectangle. Changed to use box layout so the label does not take up more
space than it needs.

Fix two other small bugs.
1) Strings for updating flash cutoff in German. Add label multiline
for that label.
2) Tab focus going on power, even though it is not a button. Users using
tab require to tabs to go from the last highlighted region (time) to the
next (sign out).

TBR=sammiequon@google.com

(cherry picked from commit f38c9a754438b6111c91d87a910c288f472a49d4)

TBR: stevenjb@chromium.org
Test: manual
Bug:  771102 ,  742283 ,  769240 
Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456
Reviewed-on: https://chromium-review.googlesource.com/750066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#513560}
Reviewed-on: https://chromium-review.googlesource.com/767113
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#472}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/power/power_status_view.cc
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/update/tray_update.cc

Project Member

Comment 17 by sheriffbot@chromium.org, Jan 19 2018

Labels: -Merge-TBD

Sign in to add a comment