New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771097 link

Starred by 5 users
Status: Fixed
Owner:
se...@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Password is visble in password field of gmail

Reported by shruti.j...@etouch.net, Oct 3 2017 
63.0.3231.0 d6cc8b72e6cc0d79db438da47fda28971880eb87-refs/heads/master@{#505897}(32/64 bit)
 OS:Windows(7,8,10), Linux(14.04 LTS), Mac OS X(10.12.6)


What steps will reproduce the problem?
(1)Launch chrome and Sign in Gmail with valid credentials then click on  save password bubble and save password.
(2)Go for second time login page of gmail enter valid email id 
(3)after entering email-id click next and observe in password field.


Actual Result: Password is visible in password field
Expected Result: Password should not be visible in password field

This is Regression issue broken in M-63 and will soon update other bisect info.

Manual Bisect:
Good Build:63.0.3230.0
Bad Build:63.0.3231.0

Comment 1 by shruti.j...@etouch.net, Oct 3 2017

Cc: ranjitkan@chromium.org msrchandra@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
Components: Blink>Forms>Password
Labels: M-63 OS-Linux

Comment 2 by shruti.j...@etouch.net, Oct 3 2017

Labels: hasbisect-per-revision
Owner: se...@chromium.org
Status: Assigned (was: Unconfirmed)

Kindly Refer the updated Info:
GoodBuild:63.0.3230.0(Revision:505512)
Bad build:63.0.3231.0(Revision:505897)
You are probably looking for a change made after 505742 (known good), but no later than 505743 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/4702a5541d87d6f0d4413656ff3065db175c6bbd..0727466e09c7285f3c4fe6a7974bfc68fd9bbccb

Suspect:https://chromium.googlesource.com/chromium/src/+/0727466e09c7285f3c4fe6a7974bfc68fd9bbccb

@sebsg:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Thank you
actualpassword.mp4
1.3 MB View Download
expectedpassword.mp4
1.5 MB View Download

Comment 3 by shruti.j...@etouch.net, Oct 3 2017

Summary: Regression:Password is visble in password field of gmail (was: Regeression:Password is visble in password field of gmail )

Comment 4 by ranjitkan@chromium.org, Oct 3 2017

Labels: ReleaseBlock-Dev
Tagging with blocker label, please undo or reduce priority if not the case.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c28f832f0c87926662c1b9f7965fd7dd19d6b239

commit c28f832f0c87926662c1b9f7965fd7dd19d6b239
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Tue Oct 03 12:40:55 2017

Revert "[Autofill] Use ShadowDom placeholder to preview suggestions."

This reverts commit 0727466e09c7285f3c4fe6a7974bfc68fd9bbccb.

Reason for revert: Makes some passwords be visible when suggested to the user.

Bug:  771097 


Original change's description:
> [Autofill] Use ShadowDom placeholder to preview suggestions.
> 
> Bug:  753645 
> Change-Id: Idabb4d01b45aa08a71f9fc8ad1dd89b192cfb0c5
> Reviewed-on: https://chromium-review.googlesource.com/646754
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505743}

TBR=yosin@chromium.org,tkent@chromium.org,sebsg@chromium.org

Change-Id: I3a874ea052f598724831bdfcf0e16576a09353b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753645 
Reviewed-on: https://chromium-review.googlesource.com/697644
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506011}
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[delete] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/LayoutTests/fast/forms/javascript-cannot-access-suggested-value.html
[delete] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt
[delete] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value.html
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-setvalue.html
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-expected.html
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/LayoutTests/platform/win7/fast/forms/suggested-value-expected.txt
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/TextControlElement.h
[modify] https://crrev.com/c28f832f0c87926662c1b9f7965fd7dd19d6b239/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Comment 6 by shruti.j...@etouch.net, Oct 4 2017

Labels: TE-Verified-63 TE-Verified-63.0.3232.0
Note:
Retested the above issue on Canary #63.0.3232.0(PGO) on Windows(7,8,10), Linux(14.04 LTS), MAC(10.12.6) and fix is working as intended.

Thank You
verifiedpwd.mp4
2.2 MB View Download

Comment 7 by se...@chromium.org, Oct 5 2017

Status: Fixed (was: Assigned)

Comment 8 by shruti.j...@etouch.net, Oct 5 2017 

Thank You.

Comment 9 by rkalavakuntla@chromium.org, Oct 6 2017 

 Issue 772253  has been merged into this issue.
►

Sign in to add a comment