New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771095 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unnecessary action is performed on Checkbox,when we hit enter to open 'Learn more 'link

Project Member Reported by rkalavakuntla@chromium.org, Oct 3 2017

Issue description

Chrome Version:63.0.3230.0/9997.0.0 dev channel Daisy,Reks,Kip
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build >> In OOBE screen, goto 'Google Chrome OS terms page'
(2)Press Tab,till focus comes on 'Learn more' link, now hit Enter
(3)Close the sub-page that is opened and Observe the check-box(please refer video)

Actual:Unnecessary action is performed on Checkbox,when we hit enter to open'Learn more'link
Expected:Opening'Learn More' link shouldn't affect the Checkbox

This is a Regression issue as same is working fine in 62.0.3202.7/9901.3.0 dev channel Kip

Note:Issue is not seen in Linux,Windows OS

@alemate: Please confirm the issue

 
actual.mp4
7.9 MB View Download
Expected.mp4
4.4 MB View Download
Labels: ReleaseBlock-Stable
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Labels: Merge-Request-63
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddacd55df01f613c10ca98ed366a594b54c528d7

commit ddacd55df01f613c10ca98ed366a594b54c528d7
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Oct 17 18:46:36 2017

ChromeOS: Learn More link on EULA screen should not trigger adjacent checkbox.

When user hits Enter on focused "Learn More" link of the EULA screen, adjacent
checkbox was involuntary triggered. This CL fixed it.

Bug:  771095 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485
Reviewed-on: https://chromium-review.googlesource.com/721892
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509454}
[modify] https://crrev.com/ddacd55df01f613c10ca98ed366a594b54c528d7/chrome/browser/resources/chromeos/login/oobe_eula.html

Project Member

Comment 8 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a969e46dc402fb782a3862fa56472cfd635b0c99

commit a969e46dc402fb782a3862fa56472cfd635b0c99
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Oct 19 06:05:45 2017

ChromeOS: Learn More link on EULA screen should not trigger adjacent checkbox.

When user hits Enter on focused "Learn More" link of the EULA screen, adjacent
checkbox was involuntary triggered. This CL fixed it.

TBR=alemate@chromium.org

(cherry picked from commit ddacd55df01f613c10ca98ed366a594b54c528d7)

Bug:  771095 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485
Reviewed-on: https://chromium-review.googlesource.com/721892
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509454}
Reviewed-on: https://chromium-review.googlesource.com/727661
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#62}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/a969e46dc402fb782a3862fa56472cfd635b0c99/chrome/browser/resources/chromeos/login/oobe_eula.html

Status: Verified (was: Fixed)
Verified on M63 beta build (10032.32.0, 63.0.3239.42).

Sign in to add a comment