New issue
Advanced search Search tips

Issue 771087 link

Starred by 1 user
Status: Fixed
Owner:
yutak@chromium.org
Closed: Dec 2017
Cc:
tzik@chromium.org
altimin@chromium.org
dcheng@chromium.org
hirosh...@chromium.org
yutak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 786194


Sign in to add a comment

Replace same thread WTF::Function with base::Callback

Project Member Reported by tzik@chromium.org, Oct 3 2017 
As a preparation of the unification of blink::WebTaskRunner and base::SingleThreadTaskRunner, we should replace same thread WTF::Function with base::Callback.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ecdac9b23b248c0748eb4e9794affbe91d50ca

commit 77ecdac9b23b248c0748eb4e9794affbe91d50ca
Author: tzik <tzik@chromium.org>
Date: Tue Oct 03 14:00:47 2017

Add WTF::Function::Run as a replacement of its operator()

As a preparation of the unification WTF::Function into base::Callback,
this CL adds WTF::Function::Run, so that the caller can use the same
invocation interface as base::Callback.

Bug:  771087 
Change-Id: I4f56208ca4bc3988e06c4245e8ee8903061cd7a6
Reviewed-on: https://chromium-review.googlesource.com/697226
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506022}
[modify] https://crrev.com/77ecdac9b23b248c0748eb4e9794affbe91d50ca/third_party/WebKit/Source/platform/wtf/Functional.h

Comment 2 by dtapu...@chromium.org, Oct 5 2017

Components: Blink>Internals

Comment 3 by slangley@chromium.org, Oct 19 2017

Components: -Blink>Internals Blink>Internals>WTF
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bffda4cd007e678135806ec0861f046cb378e02

commit 8bffda4cd007e678135806ec0861f046cb378e02
Author: tzik <tzik@chromium.org>
Date: Fri Oct 27 15:50:21 2017

Remove WTF::Function<>::operator() and update all callers

As a preparation of merging WTF::Function and base::Callback, this CL
removes WTF::Funcion::operator(), and updates all callers to use either
rvalue or lvalue version of WTF::Function::Run(). The user of rvalue
version will use base::OnceCallback, and the others will use
base::RepeatingCallback.

Also, this CL retires most of FunctionalTest that should be covered by
base/bind_unittest.cc.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idd76066eaa00d83044443198099e71f5c3c1d216
Reviewed-on: https://chromium-review.googlesource.com/735114
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512191}
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/html/custom/CustomElementReactionTestHelpers.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/indexeddb/IDBRequestQueueItem.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/ContentSettingCallbacks.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/WebScheduler.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/bindings/Microtask.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/heap/PersistentTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
[modify] https://crrev.com/8bffda4cd007e678135806ec0861f046cb378e02/third_party/WebKit/public/platform/InterfaceRegistry.h

Comment 5 by tzik@chromium.org, Oct 31 2017

Cc: hirosh...@chromium.org
There seems the first use case of repeating cross thread WTF::Function landed today, http://crrev.com/c/727487. Its blink::InterfaceRegistry::AddInstance takes a WTF::Function as an interface factory, that is called multiple times on a foreign thread.

As cross thread repeating callbacks are not safe in general (though there may be safe usage), I originally planned not to add blink::BindCrossThreadRepeating() next to WTF::Bind(), WTF::BindRepeating() and blink::BindCrossThread().
However, we may have to add it...?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47bfa3dc4b051b303ba6da6699c6b6623975ed20

commit 47bfa3dc4b051b303ba6da6699c6b6623975ed20
Author: tzik <tzik@chromium.org>
Date: Tue Oct 31 09:39:48 2017

Remove WTF::ParamStorageTraits

This removes WTF::ParamStorageTraits, as its type conversion is no
longer used. Its type assertions are moved to CheckGCedTypeRestriction.

Bug:  771087 
Change-Id: I405fa4c38ae051dda6a1a75d3dbdd8c4a46586c7
Reviewed-on: https://chromium-review.googlesource.com/745762
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512790}
[modify] https://crrev.com/47bfa3dc4b051b303ba6da6699c6b6623975ed20/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/47bfa3dc4b051b303ba6da6699c6b6623975ed20/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp

Comment 7 by slangley@chromium.org, Oct 31 2017

Owner: tzik@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d53727e2c524a1c67bb666a19aa9b35f8e16f871

commit d53727e2c524a1c67bb666a19aa9b35f8e16f871
Author: tzik <tzik@chromium.org>
Date: Tue Oct 31 10:50:31 2017

Remove WTF::BindInternal

As WTF::BindInternal no longer does lots of things, this CL inlines it
into WTF::Bind and blink::CrossThreadBind. As a preparation to remove
WTF::Function for same thread usage.

Bug:  771087 
Change-Id: I7b24c106d3ce9676b074a19521628107b7fe7b89
Reviewed-on: https://chromium-review.googlesource.com/745742
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512799}
[modify] https://crrev.com/d53727e2c524a1c67bb666a19aa9b35f8e16f871/third_party/WebKit/Source/platform/CrossThreadFunctional.h
[modify] https://crrev.com/d53727e2c524a1c67bb666a19aa9b35f8e16f871/third_party/WebKit/Source/platform/wtf/Functional.h

Comment 10 by tzik@chromium.org, Nov 15 2017

Owner: yutak@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/751319a7355e14c4bc5b9da5289e755a4703fdc3

commit 751319a7355e14c4bc5b9da5289e755a4703fdc3
Author: tzik <tzik@chromium.org>
Date: Wed Nov 15 19:25:11 2017

Fix thread restriction check in WebTaskRunner

WTF::Closure has to stick to the thread where it's created, and it has
DCHECKs to assert that. However, once it's converted to base::Callback
in WebTaskRunner::PostTask, the DCHECK no longer works.

This CL adds DCHECKs to WebTaskRunner, and fixes callers that violate
the restriction.

Bug:  771087 
Change-Id: I04a6c25251ee8611c95fe6a6c326a99d88d5ea5c
Reviewed-on: https://chromium-review.googlesource.com/770922
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516778}
[modify] https://crrev.com/751319a7355e14c4bc5b9da5289e755a4703fdc3/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/751319a7355e14c4bc5b9da5289e755a4703fdc3/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e352299190a173e82b1dc3d17c8f8e66726e3a

commit d9e352299190a173e82b1dc3d17c8f8e66726e3a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Nov 16 08:43:41 2017

Move out threading DCHECK from WTF::Function.

This patch is largely based on tzik's WIP patch:
https://chromium-review.googlesource.com/c/chromium/src/+/742824

Bug:  771087 
Change-Id: I20e2eb5ef09911a19e3b268e45ce6187d8edeffa
Reviewed-on: https://chromium-review.googlesource.com/765749
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517030}
[modify] https://crrev.com/d9e352299190a173e82b1dc3d17c8f8e66726e3a/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a406b63494f748990356adb0ccbec1ebd42615c2

commit a406b63494f748990356adb0ccbec1ebd42615c2
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Nov 17 02:06:04 2017

Revert "Move out threading DCHECK from WTF::Function."

This reverts commit d9e352299190a173e82b1dc3d17c8f8e66726e3a.

Reason for revert: Caused  http://crbug.com/786194  .

Original change's description:
> Move out threading DCHECK from WTF::Function.
> 
> This patch is largely based on tzik's WIP patch:
> https://chromium-review.googlesource.com/c/chromium/src/+/742824
> 
> Bug:  771087 
> Change-Id: I20e2eb5ef09911a19e3b268e45ce6187d8edeffa
> Reviewed-on: https://chromium-review.googlesource.com/765749
> Commit-Queue: Yuta Kitamura <yutak@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517030}

TBR=yutak@chromium.org,haraken@chromium.org,tzik@chromium.org

Change-Id: I716bcb1e7efd0f7a46395120e35eef95ed33d0f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  771087 
Reviewed-on: https://chromium-review.googlesource.com/775542
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517247}
[modify] https://crrev.com/a406b63494f748990356adb0ccbec1ebd42615c2/third_party/WebKit/Source/platform/wtf/Functional.h

Comment 14 by kbr@chromium.org, Nov 17 2017

Blocking: 786194

Comment 15 by kbr@chromium.org, Nov 17 2017

Blocking: -786194

Comment 16 by kbr@chromium.org, Nov 17 2017

Blockedon: 786194
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/705aca01e5d37a1f006bb1f9f1220b286f1e8b37

commit 705aca01e5d37a1f006bb1f9f1220b286f1e8b37
Author: Yuta Kitamura <yutak@chromium.org>
Date: Sat Nov 18 23:00:08 2017

Reland "Move out threading DCHECK from WTF::Function."

This is a reland of d9e352299190a173e82b1dc3d17c8f8e66726e3a
Original change's description:
> Move out threading DCHECK from WTF::Function.
> 
> This patch is largely based on tzik's WIP patch:
> https://chromium-review.googlesource.com/c/chromium/src/+/742824
> 
> Bug:  771087 
> Change-Id: I20e2eb5ef09911a19e3b268e45ce6187d8edeffa
> Reviewed-on: https://chromium-review.googlesource.com/765749
> Commit-Queue: Yuta Kitamura <yutak@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517030}

Bug:  771087 
Change-Id: I15731f6d91447796c7082d42ff9d979c9b4e40a3
Reviewed-on: https://chromium-review.googlesource.com/778219
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517723}
[modify] https://crrev.com/705aca01e5d37a1f006bb1f9f1220b286f1e8b37/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ee25a86e03bcf45aa9645c677a8c7a6507d93af

commit 0ee25a86e03bcf45aa9645c677a8c7a6507d93af
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Nov 21 08:35:47 2017

Callback passed to WebLayerTreeView::RequestDecode should be OnceCallback.

The callback object passed to WebLayerTreeView::RequestDecode() is only called
once, thus using base::OnceCallback is appropriate.

This is a self-contained clean-up step before we replace repeating
WTF::Function with base::RepeatingCallback.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I63a7fbcba93e1dc5075ece3858caddba3fbe9204
Reviewed-on: https://chromium-review.googlesource.com/778584
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518181}
[modify] https://crrev.com/0ee25a86e03bcf45aa9645c677a8c7a6507d93af/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/0ee25a86e03bcf45aa9645c677a8c7a6507d93af/cc/trees/layer_tree_host.h
[modify] https://crrev.com/0ee25a86e03bcf45aa9645c677a8c7a6507d93af/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/0ee25a86e03bcf45aa9645c677a8c7a6507d93af/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/0ee25a86e03bcf45aa9645c677a8c7a6507d93af/third_party/WebKit/public/platform/WebLayerTreeView.h
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155d3c94d1fe7d80e7c486c0b358b723fd832f8f

commit 155d3c94d1fe7d80e7c486c0b358b723fd832f8f
Author: tzik <tzik@chromium.org>
Date: Wed Nov 22 08:14:32 2017

Migrate viz::SingleReleaseCallback to OnceCallback

This converts internal Callback of SingleReleaseCallback from legacy
Callback to OnceCallback, so that the user can pass OnceCallback.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia91c8a7700610fa70b43b1b4d71c229c8f246079
Reviewed-on: https://chromium-review.googlesource.com/748342
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518564}
[modify] https://crrev.com/155d3c94d1fe7d80e7c486c0b358b723fd832f8f/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/155d3c94d1fe7d80e7c486c0b358b723fd832f8f/components/viz/common/resources/release_callback.h
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a7f3972ce32d9e0fb4e236edaca330794ca631

commit 66a7f3972ce32d9e0fb4e236edaca330794ca631
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Nov 22 13:07:02 2017

gpu::ContextSupport::SignalQuery() should take OnceCallback.

The callback argument of SignalQuery() is called only once, thus OnceCallback
is more appropriate.

This is a clean-up step before we replace repeating WTF::Function with
base::RepeatingCallback.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7331cd594947bd051263febcdf27c6014a8623e1
Reviewed-on: https://chromium-review.googlesource.com/781603
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518618}
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/cc/test/test_context_support.cc
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/cc/test/test_context_support.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/66a7f3972ce32d9e0fb4e236edaca330794ca631/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c13d8e8913b8f41df18a2599adb3d0675fd70a

commit d6c13d8e8913b8f41df18a2599adb3d0675fd70a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Dec 01 06:09:41 2017

Make WTF::RepeatingFunction an alias of base::RepeatingCallback.

This patch introduces a new function WTF::BindRepeating, which is similar to
WTF::Bind but can only be used to create a repeating callback. It returns a
value of type WTF::RepeatingFunction, which was previously an alias of WTF::
Function but is now changed to an alias of base::RepeatingCallback.

The aim of this patch is to replace all the repeating Function usages to
base::RepeatingCallback. After this patch lands, we can now safely replace
all the occurrences of WTF::RepeatingFunction to base::RepeatingCallback.

This change comes with a lot of small adjustments. The most of those are simple
migrations to WTF::BindRepeating for the creation of callbacks that would get
used as WTF::RepeatingFunction or base::RepeatingCallback. The member functions
of NFCPtr is the only exception; they explictly take base::OnceCallback (as
defined in generated mojo code), so the callbacks need to be moved.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib11a15f844930f5021dd2ab87626c3f02ff46bce
Reviewed-on: https://chromium-review.googlesource.com/790019
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520870}
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/base/bind.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/mojo/public/cpp/system/simple_watcher.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/services/service_manager/public/cpp/connector.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/services/service_manager/public/cpp/interface_provider.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/svg/SVGURIReference.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLockTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/heap/PersistentTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/public/platform/InterfaceRegistry.h
[modify] https://crrev.com/d6c13d8e8913b8f41df18a2599adb3d0675fd70a/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bd32aef02f33ba6178d6c050306d3852349013

commit 72bd32aef02f33ba6178d6c050306d3852349013
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Dec 04 11:04:01 2017

Remove &-qualified version of WTF::Function::Run().

This ensures all call sites of WTF::Function::Run() are rvalue, i.e. any
WTF::Function variable must be wrapped with std::move() before calling Run(),
such as "std::move(function).Run()".

This improves WTF::Function's compatibility with base::OnceCallback, and
makes WTF::Function ready to be replaced with base::OnceCallback.

Thanks to tzik@'s prior work to introduce std::move()s to the whole codebase,
the number of extra modifications needed is very small.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3e366365ecfa6fed6dac141f04f83cfae781401f
Reviewed-on: https://chromium-review.googlesource.com/803199
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521310}
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/72bd32aef02f33ba6178d6c050306d3852349013/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d298a4dd732f09c9a1c306a206507c123a3761e2

commit d298a4dd732f09c9a1c306a206507c123a3761e2
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Dec 05 09:39:25 2017

Replace WTF::Function with base::OnceCallback.

This patch makes WTF::Function an alias of base::OnceCallback. After
this, all the single-threaded callbacks in Blink will become base
callbacks.

This patch doesn't remove the WTF::Funtion type nor ConvertToBase-
Callback() function. The use sites of those names will be removed
individually.

Bug:  771087 
Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1
Reviewed-on: https://chromium-review.googlesource.com/807672
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521649}
[modify] https://crrev.com/d298a4dd732f09c9a1c306a206507c123a3761e2/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/d298a4dd732f09c9a1c306a206507c123a3761e2/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/d298a4dd732f09c9a1c306a206507c123a3761e2/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844e4a305521e43e26a17a704255cc3f77a23f5e

commit 844e4a305521e43e26a17a704255cc3f77a23f5e
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Dec 05 10:26:30 2017

Revert "Replace WTF::Function with base::OnceCallback."

This reverts commit d298a4dd732f09c9a1c306a206507c123a3761e2.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 521649 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyOThhNGRkNzMyZjA5YzlhMWMzMDZhMjA2NTA3YzEyM2EzNzYxZTIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/24801

Original change's description:
> Replace WTF::Function with base::OnceCallback.
> 
> This patch makes WTF::Function an alias of base::OnceCallback. After
> this, all the single-threaded callbacks in Blink will become base
> callbacks.
> 
> This patch doesn't remove the WTF::Funtion type nor ConvertToBase-
> Callback() function. The use sites of those names will be removed
> individually.
> 
> Bug:  771087 
> Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1
> Reviewed-on: https://chromium-review.googlesource.com/807672
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Yuta Kitamura <yutak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521649}

Change-Id: I60fec5e188923122bb3b090acc49cfd0f0363df1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  771087 
Reviewed-on: https://chromium-review.googlesource.com/808224
Cr-Commit-Position: refs/heads/master@{#521653}
[modify] https://crrev.com/844e4a305521e43e26a17a704255cc3f77a23f5e/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/844e4a305521e43e26a17a704255cc3f77a23f5e/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/844e4a305521e43e26a17a704255cc3f77a23f5e/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 25 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7415aba925967876af5ec81fd2e6c8f5522265ab

commit 7415aba925967876af5ec81fd2e6c8f5522265ab
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Dec 07 06:33:24 2017

Allow base callbacks everywhere in Blink.

We are now mostly ready to start replacing WTF::Function with
base callbacks. This patch updates DEPS and audit-non-blink-usage.py so
we can use base callback stuff in Blink.

Bug:  771087 , 763980
Change-Id: I8b41ab2c3e9e72279039685960b6dd1b558ee457
Reviewed-on: https://chromium-review.googlesource.com/807754
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522367}
[modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f97b587005da9ad420c1bc3c322011f3db8ced53

commit f97b587005da9ad420c1bc3c322011f3db8ced53
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Thu Dec 07 07:32:47 2017

Reland "Replace WTF::Function with base::OnceCallback."

This reverts commit 844e4a305521e43e26a17a704255cc3f77a23f5e.

Reason for revert:
The bug that caused a compilation error if DCHECKs is off is fixed.

Original change's description:
> Revert "Replace WTF::Function with base::OnceCallback."
>
> This reverts commit d298a4dd732f09c9a1c306a206507c123a3761e2.
>
> Reason for revert:
>
> Findit (https://goo.gl/kROfz5) identified CL at revision 521649 as the
> culprit for failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyOThhNGRkNzMyZjA5YzlhMWMzMDZhMjA2NTA3YzEyM2EzNzYxZTIM
>
> Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/24801
>
> Change-Id: I60fec5e188923122bb3b090acc49cfd0f0363df1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  771087 
> Reviewed-on: https://chromium-review.googlesource.com/808224
> Cr-Commit-Position: refs/heads/master@{#521653}

TBR=haraken@chromium.org,tzik@chromium.org

Bug:  771087 
Change-Id: I0b74afe02f37d128acfe909fc5027f68afedf773
Reviewed-on: https://chromium-review.googlesource.com/808704
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522377}
[modify] https://crrev.com/f97b587005da9ad420c1bc3c322011f3db8ced53/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/f97b587005da9ad420c1bc3c322011f3db8ced53/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/f97b587005da9ad420c1bc3c322011f3db8ced53/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912ecf57422fb4514abb9d2d6ed54cf424128c73

commit 912ecf57422fb4514abb9d2d6ed54cf424128c73
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Dec 07 11:06:37 2017

Remove WTF::RepeatingFunction alias.

WTF::RepeatingFunction is already an alias of base::RepeatingCallback.
This patch replaces all the existing references to WTF::RepeatingFunction,
completing the migration of WTF::RepeatingFunction.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2d9f5264a0e5076bc6da8f2687188a5978bb18ca
Reviewed-on: https://chromium-review.googlesource.com/813555
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522398}
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/svg/SVGURIReference.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/core/svg/SVGURIReference.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/platform/heap/PersistentTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
[modify] https://crrev.com/912ecf57422fb4514abb9d2d6ed54cf424128c73/third_party/WebKit/public/platform/InterfaceRegistry.h
Project Member

Comment 28 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d14497073391881a3efa6442c2ead977fb76747

commit 4d14497073391881a3efa6442c2ead977fb76747
Author: Yuta Kitamura <yutak@chromium.org>
Date: Thu Dec 07 11:07:52 2017

Remove WTF::ConvertToBaseCallback() for single-thread callbacks.

Now WTF::Bind() returns base::OnceCallback, WTF::ConvertToBaseCallback()
(for non-crossthread callbacks) is merely an identity function. This patch
removes all the use sites of it in Blink.

Note we still have WTF::ConvertToBaseCallback() for WTF::CrossThreadFunction,
and it's not removed.

Bug:  771087 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If7903bd6fcef538999b42d5b0b31b7f23a19c34a
Reviewed-on: https://chromium-review.googlesource.com/813654
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522399}
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/controller/DevToolsFrontendImpl.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/budget/BudgetService.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/cookie_store/CookieStore.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/gamepad/GamepadHapticActuator.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/media_controls/MediaDownloadInProductHelpManager.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/payments/PaymentManager.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/permissions/Permissions.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/quota/StorageManager.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/vr/latest/VR.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/vr/latest/VRFrameProvider.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/4d14497073391881a3efa6442c2ead977fb76747/third_party/WebKit/Source/platform/wtf/Functional.h
Project Member

Comment 29 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e61204dd02fd03a393001a06ad68add45c3197

commit 76e61204dd02fd03a393001a06ad68add45c3197
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Dec 08 07:38:39 2017

Replace WTF::Function with base::OnceCallback in modules/.

Now WTF::Function is an alias of base::OnceCallback, we can safely
replace all the occurrences of WTF::Function with base::OnceCallback.

Bug:  771087 
Change-Id: Ib52b05a15fc86e75c1c8968fc7978d1a7f098b28
Reviewed-on: https://chromium-review.googlesource.com/816675
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522734}
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/indexeddb/IDBRequestQueueItem.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/indexeddb/IDBRequestQueueItem.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/quota/StorageErrorCallback.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/remoteplayback/AvailabilityCallbackWrapper.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/sensor/SensorProxy.h
[modify] https://crrev.com/76e61204dd02fd03a393001a06ad68add45c3197/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
Project Member

Comment 30 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4bacc24cedefd6a187498acc7717cab99dfb139

commit b4bacc24cedefd6a187498acc7717cab99dfb139
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Dec 08 07:40:55 2017

Replace WTF::Function with base::OnceCallback in bindings/ & core/.

Now WTF::Function is an alias of base::OnceCallback, we can safely
replace all the occurrences of WTF::Function with base::OnceCallback.

Bug:  771087 
Change-Id: I08ac0fe7f76cfef196b1132e171fcb9afd4b1ded
Reviewed-on: https://chromium-review.googlesource.com/816674
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522735}
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ModulePendingScript.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/PendingScript.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/dom/ScriptedAnimationController.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/html/custom/CustomElementReactionTestHelpers.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/b4bacc24cedefd6a187498acc7717cab99dfb139/third_party/WebKit/Source/core/workers/WorkerScriptLoader.h
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/245aa90ea20d593e9303b745e203996dbea2a37a

commit 245aa90ea20d593e9303b745e203996dbea2a37a
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Dec 08 09:22:03 2017

Replace WTF::Function with base::OnceCallback in platform/.

Now WTF::Function is an alias of base::OnceCallback, we can safely
replace all the occurrences of WTF::Function with base::OnceCallback.

Bug:  771087 
Change-Id: Ifa51238ab929012e5a39ed7e0c29fc1fdc341f96
Reviewed-on: https://chromium-review.googlesource.com/816635
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522745}
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/ContentSettingCallbacks.cpp
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/ContentSettingCallbacks.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/bindings/Microtask.cpp
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/bindings/Microtask.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/scheduler/test/fake_web_view_scheduler.h
[modify] https://crrev.com/245aa90ea20d593e9303b745e203996dbea2a37a/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
Project Member

Comment 32 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2da64a827325f6b9c91482845329f2d66687cc1

commit e2da64a827325f6b9c91482845329f2d66687cc1
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Dec 11 06:59:10 2017

Remove WTF::Function alias.

All the use sites of WTF::Function are gone. Let's remove it!

Bug:  771087 
Change-Id: I4b0b82f96c92461c505dd342bb480762242736a4
Reviewed-on: https://chromium-review.googlesource.com/816641
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523049}
[modify] https://crrev.com/e2da64a827325f6b9c91482845329f2d66687cc1/third_party/WebKit/Source/platform/wtf/Functional.h

Comment 33 by yutak@chromium.org, Dec 14 2017

Status: Fixed (was: Started)
Project Member

Comment 34 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e51d8e83f2d6bfc157b9f9411cd668051050931

commit 2e51d8e83f2d6bfc157b9f9411cd668051050931
Author: Fergal Daly <fergal@chromium.org>
Date: Tue Jan 30 05:18:17 2018

Remove base::OnceCallback<void()> from disallow_list.

It was added to the whitelist in https://crrev.com/c/807754.

Bug:  771087 ,763980
Change-Id: I3f168415bba5cfcf4383c30c3ef6e66036ffc050
Reviewed-on: https://chromium-review.googlesource.com/892195
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532768}
[modify] https://crrev.com/2e51d8e83f2d6bfc157b9f9411cd668051050931/third_party/WebKit/PRESUBMIT_test.py
►

Sign in to add a comment