New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771080 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Oct 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

desktop-pwas: Old icons should not be used when updating

Project Member Reported by calamity@chromium.org, Oct 3 2017 
Bookmark apps currently inherit old icons and use them if the updated app doesn't have sizes to overwrite with. This is no longer necessary ever since icon syncing was properly implemented.

At some point in the past, the install dialog also used the installed app name if it existed, but that also seems to have been removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780f0e1f8d73edd9f8b6147f0e116d85272d2d38

commit 780f0e1f8d73edd9f8b6147f0e116d85272d2d38
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Oct 09 11:01:16 2017

[desktop-pwas] Remove icon inheritance when updating bookmark apps.

Bookmark apps had code that loaded old icons when updating and used them
if they were not replaced. In a Desktop PWA world, we should always
obey the manifest, and expunge old icons.

Bug:  771080 
Change-Id: Ib2b7bdc63db7cfec0043ba5aeb5ca6673c150bab
Reviewed-on: https://chromium-review.googlesource.com/697164
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507350}
[modify] https://crrev.com/780f0e1f8d73edd9f8b6147f0e116d85272d2d38/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/780f0e1f8d73edd9f8b6147f0e116d85272d2d38/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/780f0e1f8d73edd9f8b6147f0e116d85272d2d38/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/780f0e1f8d73edd9f8b6147f0e116d85272d2d38/chrome/browser/extensions/extension_sync_service.cc

Comment 2 by calamity@chromium.org, Oct 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment