Issue metadata
Sign in to add a comment
|
Regression: Contents on Extensions dialog box is seen chopped.
Reported by
aiman.an...@etouch.net,
Oct 3 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3231.0(Official Build)(cohort: Stable)d6cc8b72e6cc0d79db438da47fda28971880eb87-refs/heads/master@{#505897} (32/64 Bit) OS: Win(7,8,10), Linux(14.04 LTS). Test URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome, go to the above URL and click on Add to Chrome Button. 2.Observe the dialog box. Actual Result: Contents is seen chopped on extension dialog box. Expected Result: Contents should note be seen chopped. This is Regression issue broken in M-63 and will soon update other bisect info. Manual Bisect: Good Build:63.0.3226.0 Bad Build:63.0.3227.0 Note: Issue is not seen on MAC OS
,
Oct 3 2017
Using the per-revision bisect providing the bisect results, Good Build: 63.0.3226.0 (Revision: 504842 Bad Build: 63.0.3227.0(Revision: 505231) You are probably looking for a change made after 505092 (known good), but no later than 505094 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f3bd7c65886dedfdce09ec6af5d0f95907e89b1f..e0660c489e204cdb818676b2f7d45e4f3f0490b0 Suspect: https://chromium.googlesource.com/chromium/src/+/e0660c489e204cdb818676b2f7d45e4f3f0490b0 @ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Oct 3 2017
Correction: Chrome version:63.0.3230.0 (Official Build)Revision da95e4026511e4539097b7dc8e09c21cb92a0aee-refs/heads/master@{#505511} (32/64-bit)
,
Oct 3 2017
Yep, this is caused by my change. I'm trying to figure out the proper fix now.
,
Oct 3 2017
Tagging with blocker label, please undo if not the case.
,
Oct 9 2017
ellyjones@, Friendly ping to get an update on this issue as it is marked as stable blocker. Thanks..!
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/911a32e7a20eee2afe2b92bcf9bce041f8b7c61f commit 911a32e7a20eee2afe2b92bcf9bce041f8b7c61f Author: Elly Fong-Jones <ellyjones@google.com> Date: Wed Oct 11 14:08:34 2017 views: undo refactor of BulletedView This change broke the pre-Harmony layout of ExtensionInstallDialogView for reasons that aren't yet clear. To avoid leaving trunk broken for long, undo the refactor inside this dialog. Bug: 771068 Change-Id: I0b553a0646381c9efad86be926c94ba5954ca3ad Reviewed-on: https://chromium-review.googlesource.com/709656 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#507974} [modify] https://crrev.com/911a32e7a20eee2afe2b92bcf9bce041f8b7c61f/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/911a32e7a20eee2afe2b92bcf9bce041f8b7c61f/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
,
Oct 11 2017
This should be fixed on the next canary. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Oct 3 2017