New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771067 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tool tip appears out of the box in chrome://settings

Reported by vineetha...@etouch.net, Oct 3 2017

Issue description

Chrome Version : 63.0.3230.0 (Official Build)Revision da95e4026511e4539097b7dc8e09c21cb92a0aee-refs/heads/master@{#505511} (32/64-bit)
OS:Windows (7,8,10),Mac OS X(10.12.6).

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings
(2)Type search string 'gh' or 'gt' in "Search Settings" textbox and observe.

Actual: Searched tool tip appears out of the box.
Expected: Searched tool tip should not appear out of the box.

This is a regression issue broken in 'M63' and using the per-revision bisect providing the bisect results,
Good Build: 63.0.3227.0(Revision:505232)
Bad Build: 63.0.3228.0(Revision:505449)
 
You are probably looking for a change made after 505441 (known good), but no later than 505442 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/239e5b8215692feaa750b3f2b1dcc8111349ddbb..c31a7fd20c45dd90838b9886302b87e58e6d3d16

Suspect: https://chromium.googlesource.com/chromium/src/+/c31a7fd20c45dd90838b9886302b87e58e6d3d16

From the CL above, assigning the issue to the concern owner

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: This issue is not seen in Linux.

 
ActualResult.mp4
782 KB View Download
ExpectedResult.mp4
760 KB View Download
Labels: ReleaseBlock-Beta
Tagging with blocker label, please undo or reduce priority accordingly.

Thanks.!
Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/699195
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c9b6980e8778a7434e5ec131287e9dcfc771833

commit 3c9b6980e8778a7434e5ec131287e9dcfc771833
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Oct 04 02:04:35 2017

[MD settings] position search bubble on subpage rows

This CL positions the search bubble on the parent element rather than on
the grandparent.

Bug:  771067 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9936c13e3faca1145ab213fd1e9f8b6b5d4f69bd
Reviewed-on: https://chromium-review.googlesource.com/699195
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506276}
[modify] https://crrev.com/3c9b6980e8778a7434e5ec131287e9dcfc771833/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/3c9b6980e8778a7434e5ec131287e9dcfc771833/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Started)
Rechecked this issue on Canary build 63.0.3633.0 on Windows 10 and Mac 10.12.6, observed that tool tip is still not displayed at the text location. Screen shot attached.

@dschuyler: request you to please check and confirm if this is Fixed.

Thanks.!
Tool Tip.png
490 KB View Download
It looks to me like the Actual and the Expected each had a bug. In Actual, the bubble (yellow tag) was showing in the wrong place; in the Expected, the bubble wasn't showing at all.

The bubble should appear because 'gh' appears in "Latin Modern Mono Light"; and 'gt' appears in "TlwgTypewriter" which are both font names present in that subpage. Try something like 'borders' which is unlikely to be in a font name while still being on the Appearance Page to see that the bubble will not be shown.

IMO, the Fixed status is still correct.

Sign in to add a comment