Update contributing to catapult doc on Github |
|||||||
Issue descriptionhttps://catapult.gsrc.io/CONTRIBUTING.md We need the additional incantation git config remote.origin.url https://chromium.googlesource.com/catapult And the references to Rietveld need to be replaced with Gerrit (and we should probably add a link to chromium-review.googlesource.com)
,
Oct 3 2017
This was mostly addressed in https://chromium-review.googlesource.com/690445 The `git config remote.origin.url..` command is only needed for people who cloned the repo before the source of truth was changed. Since it's covered in the email thread, we didn't put it in the contributor's guide.
,
Oct 3 2017
Ah, yes, looks like the changes were made and landed. I don't know why the link I posted above (https://catapult.gsrc.io/CONTRIBUTING.md) still shows the old info with the github repo and Rietveld.
,
Oct 20 2017
The public page (#c3) is still stale. My guess is that it's serving from here: https://cs.chromium.org/chromium/infra/appengine/third_party/catapult/CONTRIBUTING.md
,
Nov 14 2017
,
Dec 29 2017
catapult.gsrc.io has been turned down.
,
Apr 5 2018
I ran into this today whilst sheriffing. I found the public page at https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md, followed the instructions, and got: $ git cl upload Credentials for the following hosts are required: github-review.com github.com These are read from /usr/local/google/home/smcgruer/.gitcookies (or legacy /usr/local/google/home/smcgruer/.netrc) You can (re)generate your credentials by visiting https://github-review.com/new-password It took me 15 minutes to find issue 731091 which solved my problem by adding the incantation from #1. I don't think this bug should be closed until the external github documentation has been fixed?
,
Apr 5 2018
Uh... ignore me. That page has been updated, and now I'm very confused as to how I ended up copy/pasting a github URL into the clone... |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by achuith@chromium.org
, Oct 3 2017