[MD Extensions] move away from PNG resources, use SVG icons instead. |
||||
Issue descriptionThere are currently 3 PNG resources used in MD extensions, error_severity_fatal.png error_severity_info.png error_severity_warning.png We should migrate to use SVG icons. Probably we already have such icons (or iron-icons does).
,
Oct 9 2017
,
Oct 14 2017
CL at https://chromium-review.googlesource.com/c/chromium/src/+/720268
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e74f9b6d9d653b7cd7ed3b8dc6052aa76cc613ac commit e74f9b6d9d653b7cd7ed3b8dc6052aa76cc613ac Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Oct 16 21:20:42 2017 [MD extensions] remove png error icons, use svg instead This CL removes the info, warning, and error png icons and replaces them with info, warning, and error svg Material Design icons. Bug: 770985 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id2d3c6b7b8b0ee40a0752aa6b716c233a9a7a79b Reviewed-on: https://chromium-review.googlesource.com/720268 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#509176} [modify] https://crrev.com/e74f9b6d9d653b7cd7ed3b8dc6052aa76cc613ac/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/e74f9b6d9d653b7cd7ed3b8dc6052aa76cc613ac/chrome/browser/resources/md_extensions/error_page.js [delete] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/browser/resources/md_extensions/error_severity_fatal.png [delete] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/browser/resources/md_extensions/error_severity_info.png [delete] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/browser/resources/md_extensions/error_severity_warning.png [modify] https://crrev.com/e74f9b6d9d653b7cd7ed3b8dc6052aa76cc613ac/chrome/test/data/webui/extensions/extension_error_page_test.js
,
Oct 16 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Oct 3 2017