New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770984 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Sync tests

Project Member Reported by jzw@chromium.org, Oct 3 2017

Issue description

Add some tests for sync related code in //ios/web_view.
 

Comment 1 by jzw@chromium.org, Oct 16 2017

Labels: OS-iOS

Comment 2 by sczs@chromium.org, Oct 18 2017

Components: Services>SignIn
Owner: jlebel@chromium.org
Status: Assigned (was: Untriaged)
jlebel@ could you PTAL.

Comment 3 by sczs@chromium.org, Oct 18 2017

Components: -Services>SignIn
Owner: jzw@chromium.org
Re-Assigning to jzw@ since this seems to be an iGSA tracking bug.
Description: Show this description
Summary: Sync tests (was: Signin tests)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81986bb59993e79a9ce489dce57ff76bfb0febec

commit 81986bb59993e79a9ce489dce57ff76bfb0febec
Author: John Z Wu <jzw@chromium.org>
Date: Fri Oct 05 22:23:03 2018

Add unit tests for CWVSyncControllerDelegate.

Bug: 770984
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iad12bba9a759ba69771606144d8cec7f68b61eb2
Reviewed-on: https://chromium-review.googlesource.com/c/1257891
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597342}
[modify] https://crrev.com/81986bb59993e79a9ce489dce57ff76bfb0febec/ios/web_view/internal/sync/cwv_sync_controller_unittest.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4782f4ffe49c07e9da44a6bcac91415d77611853

commit 4782f4ffe49c07e9da44a6bcac91415d77611853
Author: John Z Wu <jzw@chromium.org>
Date: Sat Oct 13 06:41:11 2018

Additional tests for CWVSyncController.

1. Test |currentIdentity|.
2. Test |passphraseNeeded| and |unlockWithPassphrase:|.

Bug: 770984
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8dd57cd0aeb772b24aaeffc6a0b833dba1e866fe
Reviewed-on: https://chromium-review.googlesource.com/c/1278991
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599493}
[modify] https://crrev.com/4782f4ffe49c07e9da44a6bcac91415d77611853/ios/web_view/internal/sync/cwv_sync_controller_unittest.mm

Sign in to add a comment