Translate tests |
|||
Issue descriptionShould add some unit tests for translate.
,
Oct 18 2017
Assigning to jzw@ since this seem to be a tracking bug for iGSA related work.
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f942bab7f82bcf06ec1d19121c854719cb9cf65c commit f942bab7f82bcf06ec1d19121c854719cb9cf65c Author: John Z Wu <jzw@chromium.org> Date: Thu Feb 22 18:39:12 2018 Unit tests for CWVTranslationLanguage and CWVTranslationPolicy. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab552ec27351eb8d5b34902f909d96a32b3a785e Reviewed-on: https://chromium-review.googlesource.com/929345 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#538496} [modify] https://crrev.com/f942bab7f82bcf06ec1d19121c854719cb9cf65c/ios/web_view/BUILD.gn [add] https://crrev.com/f942bab7f82bcf06ec1d19121c854719cb9cf65c/ios/web_view/internal/translate/cwv_translation_language_unittest.mm [add] https://crrev.com/f942bab7f82bcf06ec1d19121c854719cb9cf65c/ios/web_view/internal/translate/cwv_translation_policy_unittest.mm
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af290010a4693194d768746454f62bb1fae8a44 commit 3af290010a4693194d768746454f62bb1fae8a44 Author: John Z Wu <jzw@chromium.org> Date: Tue Feb 27 17:51:26 2018 Change CWVTranslationController dependency injection to use init. This will help in writing tests for CWVTranslationController. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8f0b67e14872e654fcf276f0fba20dab4289b6b9 Reviewed-on: https://chromium-review.googlesource.com/939045 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539494} [modify] https://crrev.com/3af290010a4693194d768746454f62bb1fae8a44/ios/web_view/internal/cwv_web_view.mm [modify] https://crrev.com/3af290010a4693194d768746454f62bb1fae8a44/ios/web_view/internal/translate/cwv_translation_controller.mm [modify] https://crrev.com/3af290010a4693194d768746454f62bb1fae8a44/ios/web_view/internal/translate/cwv_translation_controller_internal.h [modify] https://crrev.com/3af290010a4693194d768746454f62bb1fae8a44/ios/web_view/internal/translate/web_view_translate_client.mm [modify] https://crrev.com/3af290010a4693194d768746454f62bb1fae8a44/ios/web_view/public/cwv_translation_controller.h
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5cb97f4cbe0eca360526fbfe5cdc2f67003f5b9 commit b5cb97f4cbe0eca360526fbfe5cdc2f67003f5b9 Author: John Z Wu <jzw@chromium.org> Date: Wed Feb 28 02:51:03 2018 CWVTranslationController unit tests for delegate callbacks. Follow up CLs to test remaining public API. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c01436f3c98c8cfb4d46217a9862904508ea80e Reviewed-on: https://chromium-review.googlesource.com/939993 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539676} [modify] https://crrev.com/b5cb97f4cbe0eca360526fbfe5cdc2f67003f5b9/ios/web_view/BUILD.gn [add] https://crrev.com/b5cb97f4cbe0eca360526fbfe5cdc2f67003f5b9/ios/web_view/internal/translate/cwv_translation_controller_unittest.mm
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d17cf1975cb181e0b28f80abcc118a507a2afd3f commit d17cf1975cb181e0b28f80abcc118a507a2afd3f Author: John Z Wu <jzw@chromium.org> Date: Tue Mar 06 02:05:06 2018 Add unit tests for CWVTranslationController APIs related to CWVTranslationPolicys. Tests that CWVTranslationController can properly set and read policies for both languages and page hosts. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iac693f6ab83224cc55b234113a37f5f5c907a28b Reviewed-on: https://chromium-review.googlesource.com/949825 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#541027} [modify] https://crrev.com/d17cf1975cb181e0b28f80abcc118a507a2afd3f/ios/web_view/internal/translate/cwv_translation_controller_unittest.mm
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1989dbe11f48dfa285ebc04b0fb00f064e5cb547 commit 1989dbe11f48dfa285ebc04b0fb00f064e5cb547 Author: John Z Wu <jzw@chromium.org> Date: Thu Mar 15 21:01:37 2018 Unit tests for remaining CWVTranslationController methods. Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I237fe77422971a18476d85b60c1ad67d60aa39bd Reviewed-on: https://chromium-review.googlesource.com/963643 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#543492} [modify] https://crrev.com/1989dbe11f48dfa285ebc04b0fb00f064e5cb547/ios/web_view/BUILD.gn [modify] https://crrev.com/1989dbe11f48dfa285ebc04b0fb00f064e5cb547/ios/web_view/internal/translate/cwv_translation_controller_unittest.mm [add] https://crrev.com/1989dbe11f48dfa285ebc04b0fb00f064e5cb547/ios/web_view/internal/translate/fake_web_view_translate_client.h [add] https://crrev.com/1989dbe11f48dfa285ebc04b0fb00f064e5cb547/ios/web_view/internal/translate/fake_web_view_translate_client.mm [modify] https://crrev.com/1989dbe11f48dfa285ebc04b0fb00f064e5cb547/ios/web_view/internal/translate/web_view_translate_client.h
,
Oct 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jzw@chromium.org
, Oct 16 2017