New issue
Advanced search Search tips

Issue 770971 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

fast/forms/suggested-value.html fails on Win7

Project Member Reported by rdevlin....@chromium.org, Oct 2 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09213deb7b16aea386d27883a73ba4b1860d7e1c

commit 09213deb7b16aea386d27883a73ba4b1860d7e1c
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 02 23:54:58 2017

[Sheriff] Update expectations for fast/forms/suggested-value.html

webkit_layout_tests failing on Win7

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56163

TBR=mkwst@chromium.org

Bug: 770971
Notry: True
Change-Id: I35034ffbbd1a0d727920855544b8d8519895156d
Reviewed-on: https://chromium-review.googlesource.com/696131
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505860}
[modify] https://crrev.com/09213deb7b16aea386d27883a73ba4b1860d7e1c/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by rtoy@chromium.org, Oct 3 2017

Components: -Blink Blink>Forms

Comment 3 by tkent@chromium.org, Oct 5 2017

Labels: -OS-Linux OS-Windows
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56163

With this page, we can know the culprit CL.  We should have reverted the CL instead of marking the test in TestExpectations file.

The culprit CL was reverted for another reason. #505860 should be reverted too.

Cc: tkent@chromium.org
> With this page, we can know the culprit CL.  We should have reverted the CL instead of marking the test in TestExpectations file.

It's not always obvious which CL is responsible for the breakage out of 20 possible culprits, especially when a sheriff doesn't work in the area of the failing test.  Ideally, we try to revert the CL that caused the breakage, but the top priority is to keep the tree in a good state.

If the breaking CL has been removed, I'm happy to revert revision 505860.  For posterity, and my own information, which was the culprit CL of the 20?

Comment 5 by tkent@chromium.org, Jan 9 2018

Cc: -tkent@chromium.org
Owner: se...@chromium.org
Summary: fast/forms/suggested-value.html fails on Win7 (was: fast/forms/suggested-value.html flaky on Win7)
#505743 touched the test.
I think The CL was relanded and the failure restarted.

Sign in to add a comment