Issue metadata
Sign in to add a comment
|
MD Settings: Side nav layout slightly broken. |
||||||||||||||||||||||
Issue descriptionSee attached screenshot. Observe extra space below the "Advanced" button. Bisection landed on https://chromium.googlesource.com/chromium/src/+log/c0a9caa5d5c6c6cb660b190c842dc0c920a91f84..a32a6e936524a3ea411a887753d0cdee9a65af93 The only settings related CL seems https://chromium.googlesource.com/chromium/src/+/c31a7fd20c45dd90838b9886302b87e58e6d3d16 @dschuyler: Can you take a look?
,
Oct 3 2017
Issue 771052 has been merged into this issue.
,
Oct 3 2017
,
Oct 3 2017
CL at https://chromium-review.googlesource.com/c/chromium/src/+/699155
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd107a7eafad8a1e638a085c1779151160236a76 commit bd107a7eafad8a1e638a085c1779151160236a76 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Oct 04 00:28:43 2017 [MD settings] fix menu separator This CL changes the menuSeparator used in the side nav to have more context (to make it distinct from a vertical .separator). Bug: 770967 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iea9adb01d9493f02d331e9be7450645b489be626 Reviewed-on: https://chromium-review.googlesource.com/699155 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#506240} [modify] https://crrev.com/bd107a7eafad8a1e638a085c1779151160236a76/chrome/browser/resources/settings/settings_menu/settings_menu.html
,
Oct 4 2017
,
Oct 17 2017
Issue 773391 has been merged into this issue.
,
Nov 8 2017
10032.30.0, 63.0.3239.39 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Oct 2 201717.7 KB
17.7 KB View Download