New issue
Advanced search Search tips

Issue 770906 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Participants' hotlists:
CRD-iOS-accessibility


Sign in to add a comment

[CRD iOS] [Accessibility] Remeber PIN switch/label is hard to trigger

Project Member Reported by yuweih@chromium.org, Oct 2 2017

Issue description

Currently the remember PIN switch is only triggered when the user precisely taps either the switch control or the label, which is particularly bad for visually impaired users.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4068a08b8b171d4c2f80070b022043ab0fc6d832

commit 4068a08b8b171d4c2f80070b022043ab0fc6d832
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Oct 03 18:33:42 2017

[CRD iOS] Enlarge touch area to toggle the pairing switch

This CL makes a parent view for pairingSwitch and pairingLabel to handle
the tap gesture, so that we can enlarge the toggle area to a rectangle
that covers both the switch and the label with a 5pt margin on all four
edges.

Bug:  770906 
Change-Id: Icb1314aebefbbdbb41b14691cf8f392e403c5b37
Reviewed-on: https://chromium-review.googlesource.com/696298
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506111}
[modify] https://crrev.com/4068a08b8b171d4c2f80070b022043ab0fc6d832/remoting/ios/app/pin_entry_view.mm

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae4f493da1cc80cf4a6a7c2a2c3247e66c64225e

commit ae4f493da1cc80cf4a6a7c2a2c3247e66c64225e
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Oct 04 22:08:52 2017

[CRD iOS] Fix the margin of the remember PIN view

The anchor is the height anchor so the constant should be 2x the margin.

Bug:  770906 
Change-Id: Ia82073246d8224791478781efc4e73e9f69f43f0
Reviewed-on: https://chromium-review.googlesource.com/701399
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506535}
[modify] https://crrev.com/ae4f493da1cc80cf4a6a7c2a2c3247e66c64225e/remoting/ios/app/pin_entry_view.mm

Labels: M-64
Status: Verified (was: Fixed)
Verified Fixed in 34.0.3261.0

Sign in to add a comment