New issue
Advanced search Search tips

Issue 770891 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 773882



Sign in to add a comment

GLTF parser doesn't handle conversion between URL and filepath on Windows

Project Member Reported by billorr@chromium.org, Oct 2 2017

Issue description

Fix up the GLTF parser, and enable the associated unit tests on Windows.

 
Status: Available (was: Untriaged)
Components: Tests>Disabled
Labels: VR-Desktop
Blocking: 773882
Components: Tests>Disabled
Labels: Test-Disabled
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba54be035386ccaf529dc3e2fb0574558d0f5e0

commit 2ba54be035386ccaf529dc3e2fb0574558d0f5e0
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Feb 20 20:16:45 2018

[vr] Use procedural controller, remove GLTF controller and related code

Use the procedural controller instead of the GLTF controller. Also
remove the GLTF resource and the related parser since they are now
unused. The GLTF parser can be re-submitted later when we have a use
for it.

Also reduce the number of polys of the procedural controller to avoid a
perf regression.

Bug:  799606 , 779108,  770891 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I93209628fbcf20cf708b47c78689a951851f9b4b
Reviewed-on: https://chromium-review.googlesource.com/922161
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537865}
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/OWNERS
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/OWNERS
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/ddcontroller.glb
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_app.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_idle.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_system.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_touchpad.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell_resources.grd
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/controller_mesh.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/controller_mesh.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/controller.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/controller.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/elements/gltf_controller.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/elements/gltf_controller.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/keyboard.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/ui_element_name.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_asset.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_asset.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser_unittest.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/model/model.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/constants.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample.bin
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample.glb
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample_external.gltf
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample_inline.gltf
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/chrome_paks.gni
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/tools/gritsettings/resource_ids

Comment 8 by tiborg@chromium.org, Feb 20 2018

GLTF parser has been removed.
Status: WontFix (was: Available)
Obsolete - the parser has been removed.

Sign in to add a comment