New issue
Advanced search Search tips

Issue 770882 link

Starred by 1 user
Status: Verified
Owner:
mahmadi@chromium.org
Closed: Oct 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

UITextfield should get focus if any part of the field (Incl. label) is tapped

Project Member Reported by mahmadi@chromium.org, Oct 2 2017 
In Payment Request editors on iOS, UITextfield should get focus if any part of the field (Incl. label, excl. the validation message) is tapped. Currently, the UITextField gets focus if it is directly tapped which can be difficult to achieve because the UITextField makes up only a portion of the field's footprint both in height and in width.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e24d103b035c2a369c260b02ff47a9d3c77f554

commit 8e24d103b035c2a369c260b02ff47a9d3c77f554
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Oct 03 16:16:34 2017

[PR] Gives UITextField focus when any part of the text field is tapped.

Bug:  770882 
Change-Id: I73c566eae2e233801f55af0c77cd50304f9b8f23
Reviewed-on: https://chromium-review.googlesource.com/696189
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506060}
[modify] https://crrev.com/8e24d103b035c2a369c260b02ff47a9d3c77f554/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm

Comment 2 by mahmadi@chromium.org, Oct 3 2017

Status: Fixed (was: Started)

Comment 3 by shbarezer@chromium.org, Oct 10 2017

Status: Verified (was: Fixed)
Verified in 63.0.3237.0 Canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11

UITextfield gets focused if any part of the field is tapped (Incl. label)
UITextfield does not get focus when tapping on 'Required Field' (excl. the validation message)
Looks good
►

Sign in to add a comment