New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770878 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 753595



Sign in to add a comment

Create ToDBPath/FromDBPath similar as DBTime in offline_time_utils

Project Member Reported by romax@chromium.org, Oct 2 2017

Issue description

Move ToDatabaseTime/FromDatabaseTime to a new file, together with the handling of translating base::FilePath in various tasks.
 

Comment 1 by romax@chromium.org, Oct 2 2017

Blocking: 753595
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c16ce88057b6cc5117d9577ca510e8f41617e701

commit c16ce88057b6cc5117d9577ca510e8f41617e701
Author: Yafei Duan <romax@chromium.org>
Date: Wed Oct 11 19:23:58 2017

[Offline Pages] Reorganizing StoreUtils and remove ModelUtils.

Reorganizing OfflinePageStoreUtils and OfflinePageModelUtils:
1. Renamed OfflinePageStoreUtils to OfflineStoreUtils, indicating it's
   higher level and could be accessed from all Offline Pages projects.
2. Moved offline id generation to StoreUtils.
3. Moved ItemActionStatus translation back to the AddPageTask, which is
   the only class using the function.
4. Removed ModelUtils.
5. Changed to using namespaces rather than static methods in a class.
6. Updated usage of util methods, including background/, prefetching/
   and model/.

Bug:  770878 
Change-Id: I64d54211e0107e637cf3e9095d32f199fafc19a5
Reviewed-on: https://chromium-review.googlesource.com/701410
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508062}
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/BUILD.gn
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/add_page_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/add_page_task_unittest.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/clear_storage_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/create_archive_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/delete_page_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/get_pages_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/mark_page_accessed_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/offline_page_item_generator.cc
[delete] https://crrev.com/6459d0ca6136551b1054b2e6c4316084beeaa436/components/offline_pages/core/model/offline_store_utils.cc
[delete] https://crrev.com/6459d0ca6136551b1054b2e6c4316084beeaa436/components/offline_pages/core/model/offline_store_utils.h
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/offline_page_metadata_store_sql.cc
[add] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/offline_store_utils.cc
[add] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/offline_store_utils.h
[delete] https://crrev.com/6459d0ca6136551b1054b2e6c4316084beeaa436/components/offline_pages/core/offline_time_utils.cc
[delete] https://crrev.com/6459d0ca6136551b1054b2e6c4316084beeaa436/components/offline_pages/core/offline_time_utils.h
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/add_unique_urls_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/download_archives_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/download_cleanup_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/download_completed_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/import_archives_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/metrics_finalization_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/prefetch_item.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/stale_entry_finalizer_task.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/store/prefetch_downloader_quota.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/store/prefetch_store_test_util.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/store/prefetch_store_unittest.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/store/prefetch_store_utils.cc
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/store/prefetch_store_utils.h
[modify] https://crrev.com/c16ce88057b6cc5117d9577ca510e8f41617e701/components/offline_pages/core/prefetch/task_test_base.cc

Comment 3 by romax@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment